feat: add C ndarray interface and refactor implementation for `stats/base/dvariancepn` #4688

0PrashantYadav0 · 2025-01-10T19:05:14Z

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

adds C ndarray interface for stats/base/dvariancepn
refactors JavaScript implementation
updates tests, docs, examples and benchmarks

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

stdlib-bot · 2025-01-11T06:54:51Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dvariancepn	$\color{green}395/395$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}395/395$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: failed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

aayush0325

pointed out some inaccuracies in the C implementation of the ndarray interface in src/main.c, it's worth working on this and passing the CI before further review

lib/node_modules/@stdlib/stats/base/dvariancepn/src/main.c

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

aayush0325

I would prefer that you avoid making changes unless necessary while refactoring. Kindly minimize all unnecessary diff

lib/node_modules/@stdlib/stats/base/dvariancepn/test/test.ndarray.native.js

0PrashantYadav0 · 2025-01-12T13:09:37Z

Thank you so much @aayush0325 for help. @Planeshifter @kgryte Please review this pr and merge this coz other my other 2 pr are depended on this one.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md

lib/node_modules/@stdlib/stats/base/dvariancepn/docs/repl.txt

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

0PrashantYadav0 · 2025-01-13T14:41:20Z

@Neerajpathak07 Thank you for your review. I make the changes you asked for.

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md

Neerajpathak07 · 2025-01-13T14:58:27Z

@0PrashantYadav0
Would suggest you to make similar changes in your other PR's related to ndarray interface.
As it makes it difficult for the maintainers to review it, had similar issues in my PR so thought of advising you to prevent some thing similar

Neerajpathak07 · 2025-01-18T13:54:09Z

@0PrashantYadav0 LGTM

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

0PrashantYadav0 · 2025-01-29T04:30:40Z

@kgryte Will you review this pr please. Thank you.

Neerajpathak07 · 2025-01-29T06:42:07Z

@0PrashantYadav0 apparently the maintainers are busy with the GSoC org registrations which should be done by the end of the week. Please wait for the time being they'll surely take a look at it.

0PrashantYadav0 · 2025-01-29T06:45:16Z

No worries. Thank you for informing me. @Neerajpathak07.

aayush0325

lgtm

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/stats/base/dvariancepn/src/main.c

Signed-off-by: Athan <[email protected]>

kgryte

LGTM

…base/dvariancepn` PR-URL: stdlib-js#4688 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 10, 2025

0PrashantYadav0 added 3 commits January 11, 2025 12:27

aayush0325 requested changes Jan 12, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/src/main.c Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/stats/base/dvariancepn/src/main.c Outdated Show resolved Hide resolved

aayush0325 added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 12, 2025

aayush0325 requested changes Jan 12, 2025

View reviewed changes

aayush0325 reviewed Jan 12, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/test/test.ndarray.native.js Outdated Show resolved Hide resolved

0PrashantYadav0 requested a review from aayush0325 January 12, 2025 13:17

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 12, 2025

0PrashantYadav0 mentioned this pull request Jan 12, 2025

feat: add C ndarray interface and refactor implementation for stats/base/dstdev #4685

Closed

1 task

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/docs/repl.txt Outdated Show resolved Hide resolved

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/docs/repl.txt Outdated Show resolved Hide resolved

0PrashantYadav0 requested a review from Neerajpathak07 January 13, 2025 14:40

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

0PrashantYadav0 requested a review from Neerajpathak07 January 18, 2025 13:06

aayush0325 approved these changes Jan 18, 2025

View reviewed changes

kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jan 18, 2025

kgryte reviewed Jan 18, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

kgryte added Needs Changes Pull request which needs changes before being merged. Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Jan 18, 2025

0PrashantYadav0 requested review from aayush0325 and kgryte January 19, 2025 07:03

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 19, 2025

aayush0325 approved these changes Feb 3, 2025

View reviewed changes

kgryte reviewed Feb 3, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

kgryte reviewed Feb 3, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

kgryte reviewed Feb 3, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

2eb9370

Signed-off-by: Athan <[email protected]>

kgryte reviewed Feb 3, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dvariancepn/src/main.c Show resolved Hide resolved

style: insert empty line before comment

5a12929

Signed-off-by: Athan <[email protected]>

kgryte approved these changes Feb 3, 2025

View reviewed changes

kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Feb 3, 2025

kgryte merged commit 7feea68 into stdlib-js:develop Feb 3, 2025
14 checks passed

Uh oh!

feat: add C ndarray interface and refactor implementation for stats/base/dvariancepn #4688

feat: add C ndarray interface and refactor implementation for stats/base/dvariancepn #4688

Uh oh!

Conversation

0PrashantYadav0 commented Jan 10, 2025 • edited by kgryte Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jan 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

aayush0325 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aayush0325 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0PrashantYadav0 commented Jan 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0PrashantYadav0 commented Jan 13, 2025

Uh oh!

Uh oh!

Neerajpathak07 commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neerajpathak07 commented Jan 18, 2025

Uh oh!

Uh oh!

0PrashantYadav0 commented Jan 29, 2025

Uh oh!

Neerajpathak07 commented Jan 29, 2025

Uh oh!

0PrashantYadav0 commented Jan 29, 2025

Uh oh!

aayush0325 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: add C ndarray interface and refactor implementation for `stats/base/dvariancepn` #4688

feat: add C ndarray interface and refactor implementation for `stats/base/dvariancepn` #4688

0PrashantYadav0 commented Jan 10, 2025 •

edited by kgryte

Loading

stdlib-bot commented Jan 11, 2025 •

edited

Loading

aayush0325 left a comment •

edited

Loading

aayush0325 left a comment •

edited

Loading

Neerajpathak07 commented Jan 13, 2025 •

edited

Loading