Skip to content

feat: add lapack/base/zlacgv #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat: add lapack/base/zlacgv #4709

wants to merge 4 commits into from

Conversation

@rreusser
Copy link
Member

@rreusser rreusser commented Jan 12, 2025 •
edited
Loading

Towards #2464.

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/zlacgv.

Related Issues

Does this pull request have any related issues?

No

Questions

  • It says in a couple places this is part of BLAS level-1, but that's not quite right. It's in LAPACK BLAS-like level 1. I'm not sure if this distinction is important.
  • It might be helpful for me to discuss with maintainers about linting and verifications. I always run into various linter problems and use no-verify to unblock without actually fixing.

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@rreusser rreusser marked this pull request as ready for review January 12, 2025 04:43
@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. labels Jan 12, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@rreusser rreusser changed the title feat: add blas/lapack/zlacgv feat: addlapack/base/zlacgv Jan 12, 2025
@rreusser rreusser changed the title feat: addlapack/base/zlacgv feat: add lapack/base/zlacgv Jan 12, 2025
@rreusser
feat: add lapack/base/zlacgv
ac54e7c 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@rreusser
update copyright and fix misnamed files
dd20b8e 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: failed
---
@rreusser
update copyright and fix misnamed files
2fec23f 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
@rreusser
Merge branch 'zlacgv' of github.com:rreusser/stdlib into zlacgv
2fa0960
@rreusser
Copy link
Member Author

I should not have rebased, and as a result, git seems unable to reconcile the history. Something went badly wrong in this branch, so I'm going to delete and recreate this PR.

@rreusser rreusser closed this Jan 12, 2025
@kgryte
Copy link
Member

kgryte commented Jan 12, 2025

Yeah, once you've pushed to your remote, at least on your local branch, doing a normal merge commit will lead to fewer problems. Given that we squash merge, rebasing on branches is not as critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rreusser @stdlib-bot @kgryte