feat: add C ndarray implementation for stats/base/dmeanvarpn
#4720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
stdlib-bot
added
Statistics
lib/node_modules/@stdlib/stats/base/dmeanvarpn/benchmark/c/benchmark.length.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dmeanvarpn/benchmark/c/benchmark.length.c
Outdated
Show resolved
Hide resolved
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Contributor
Author
|
/stdlib update-copyright-years |
stdlib-bot
added
bot: In Progress
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: passed
- task: run_c_benchmarks
status: passed
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
DhruvArvindSingh
changed the title
stats/base/dmeanvarpnndarray implementation for stats/base/dmeanvarpn
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: passed
- task: run_c_examples
status: passed
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: passed
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: passed
---
aayush0325
requested changes
Feb 3, 2025
Comment on lines
+257
to
+260
| double x[] ={ 1.0, -2.0, 2.0 }; | ||
| double out[2]; | ||
| stdlib_strided_dmeanvarpn( x.length, 1, x, 1, out, 1 ); | ||
| // Out = [ ~0.3333, ~4.3333 ] |
Member
There was a problem hiding this comment.
Suggested change
| double x[] ={ 1.0, -2.0, 2.0 }; | |
| double out[2]; | |
| stdlib_strided_dmeanvarpn( x.length, 1, x, 1, out, 1 ); | |
| // Out = [ ~0.3333, ~4.3333 ] | |
| const double x[] ={ 1.0, -2.0, 2.0 }; | |
| double out[] = { 0.0, 0.0 }; | |
| stdlib_strided_dmeanvarpn( x.length, 1, x, 1, out, 1 ); |
| - **correction**: `[in] double` degrees of freedom adjustment. | ||
| - **X**: `[in] double*` input array. | ||
| - **strideX**: `[in] CBLAS_INT` stride length for `X`. | ||
| - **Out**: `[in] double*` Output array. |
Member
There was a problem hiding this comment.
Suggested change
| - **Out**: `[in] double*` Output array. | |
| - **Out**: `[out] double*` Output array. |
Comment on lines
+281
to
+284
| const double x[] = { 1.0, -2.0, 2.0 }; | ||
|
|
||
| stdlib_strided_dmeanvarpn_ndarray( x.length, 1, x, 1, 0, out, 1, 0 ); | ||
| // Out = [ ~0.3333, ~4.3333 ] |
| - **X**: `[in] double*` input array. | ||
| - **strideX**: `[in] CBLAS_INT` stride length for `X`. | ||
| - **offsetX**: `[in] CBLAS_INT` `X` starting index. | ||
| - **Out**: `[in] double*` Output array. |
Member
There was a problem hiding this comment.
Suggested change
| - **Out**: `[in] double*` Output array. | |
| - **Out**: `[out] double*` Output array. |
Member
There was a problem hiding this comment.
this is also missing changes in the JavaScript docs regarding removing the usage of math/base/special/floor in examples
| */ | ||
|
|
||
| #include "stdlib/stats/base/dmeanvarpn.h" | ||
| #include "stdlib/blas/base/shared.h" |
Member
There was a problem hiding this comment.
why is this being removed? it should be there since we're wrapping function calls in API_SUFFIX which comes from this header
| */ | ||
|
|
||
| #include "stdlib/stats/base/dmeanvarpn.h" | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
no need for extra newline
Comment on lines
-26
to
-34
| * ## Method | ||
| * | ||
| * - This implementation uses a two-pass approach, as suggested by Neely (1966). | ||
| * | ||
| * ## References | ||
| * | ||
| * - Neely, Peter M. 1966. "Comparison of Several Algorithms for Computation of Means, Standard Deviations and Correlation Coefficients." _Communications of the ACM_ 9 (7). Association for Computing Machinery: 496–99. doi:[10.1145/365719.365958](https://doi.org/10.1145/365719.365958). | ||
| * - Schubert, Erich, and Michael Gertz. 2018. "Numerically Stable Parallel Computation of (Co-)Variance." In _Proceedings of the 30th International Conference on Scientific and Statistical Database Management_. New York, NY, USA: Association for Computing Machinery. doi:[10.1145/3221269.3223036](https://doi.org/10.1145/3221269.3223036). | ||
| * |
Member
There was a problem hiding this comment.
references are important, no need to remove them
Comment on lines
+57
to
81
| CBLAS_INT ix; | ||
| CBLAS_INT io; | ||
| CBLAS_INT n; | ||
| double mu; | ||
| double dN; | ||
| double M2; | ||
| double M; | ||
| double d; | ||
| double c; | ||
| double n; | ||
| double i; | ||
|
|
||
| if ( strideX < 0 ) { | ||
| ix = (1-N) * strideX; | ||
| } else { | ||
| ix = 0; | ||
| } | ||
| if ( strideOut < 0 ) { | ||
| io = -strideOut; | ||
| } else { | ||
| io = 0; | ||
| } | ||
| ix = offsetX; | ||
| io = offsetOut; | ||
| if ( N <= 0 ) { | ||
| Out[ io ] = 0.0 / 0.0; // NaN | ||
| Out[ io+strideOut ] = 0.0 / 0.0; // NaN | ||
| Out[ io ] = 0.0/0.0; | ||
| Out[ io + strideOut ] = 0.0/0.0; | ||
| return; | ||
| } | ||
| dN = (double)N; | ||
| n = dN - correction; | ||
| n = N - correction; | ||
| if ( N == 1 || strideX == 0 ) { | ||
| Out[ io ] = X[ ix ]; | ||
| if ( n <= 0.0 ) { | ||
| Out[ io+strideOut ] = 0.0 / 0.0; // NaN | ||
| Out[ io+strideOut ] = 0.0/0.0; | ||
| } else { | ||
| Out[ io+strideOut ] = 0.0; | ||
| } |
Member
There was a problem hiding this comment.
this is copied from the JS ndarray implementation, i would prefer that you refactor the existing C implementation only
Member
There was a problem hiding this comment.
this would avoid implicit typecasting etc, for eg see changes on line 101
| Out[ io ] = X[ ix ]; | ||
| if ( n <= 0.0 ) { | ||
| Out[ io+strideOut ] = 0.0 / 0.0; // NaN | ||
| Out[ io+strideOut ] = 0.0/0.0; |
Member
There was a problem hiding this comment.
Suggested change
| Out[ io+strideOut ] = 0.0/0.0; | |
| Out[ io+strideOut ] = 0.0 / 0.0; // NaN |
Member
There was a problem hiding this comment.
same comment for all other instances
aayush0325
added
Needs Changes
7 tasks
kgryte
added
Obsolete
Contributor
|
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves None.
Description
This pull request:
ndarrayimplementation forstats/base/dmeanvarpn.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers