Skip to content

feat: add C implementation of stats/base/dists/weibull/skewness #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

feat: add C implementation of stats/base/dists/weibull/skewness #4769

wants to merge 14 commits into from

Conversation

yuvi-mittal
Copy link
Contributor

Resolves #3849

Description

What is the purpose of this pull request?

This pull request:

  • Add C implementation for @stdlib/stats/base/dists/weibull/skewness

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
ef48cd2 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 15, 2025
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
5cdead0 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
63e5dd1 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
fdbf73d 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
98505fd 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
8d0a428 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
8d2201d 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
d6b0185 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
b69ece4 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
f58b282 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
feat:C implementation of stats/base/dists/weibull/skewness
3272b7f 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
Merge branch 'feature/weibull-skewness' of https://github.com/yuvi-mi…
12e20d9 
…ttal/stdlib into feature/weibull-skewness

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@DhruvArvindSingh
Copy link
Contributor

DhruvArvindSingh commented Jan 16, 2025 •
edited
Loading

In the build object of manifest.json file put all the external dependencies of addon.c , main.c and include folder

Neerajpathak07
Neerajpathak07 reviewed Jan 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/manifest.json Outdated
Comment on lines 37 to 44
"@stdlib/math/base/assert/is-positive-integer",
"@stdlib/math/base/assert/is-finite",
"@stdlib/math/base/assert/is-nan",
"@stdlib/math/base/special/exp",
"@stdlib/constants/float64/ln-two",
"@stdlib/math/base/special/ln",
"@stdlib/math/base/assert/is-integer",
"@stdlib/math/base/special/gamma"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@stdlib/math/base/assert/is-positive-integer",
"@stdlib/math/base/assert/is-finite",
"@stdlib/math/base/assert/is-nan",
"@stdlib/math/base/special/exp",
"@stdlib/constants/float64/ln-two",
"@stdlib/math/base/special/ln",
"@stdlib/math/base/assert/is-integer",
"@stdlib/math/base/special/gamma"
"@stdlib/math/base/assert/is-nan",
"@stdlib/math/base/special/pow",
"@stdlib/math/base/special/sqrt",
"@stdlib/math/base/special/gamma"

since most of the header files are not used in the build there is no need to add them here and below for benchmark and examples

Neerajpathak07
Neerajpathak07 reviewed Jan 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/benchmark/benchmark.js Outdated
@@ -52,3 +52,28 @@ bench( pkg, function benchmark( b ) {
b.pass( 'benchmark finished' );
b.end();
});

bench( pkg+':direct', function benchmark( b ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this code block is necessary

Neerajpathak07
Neerajpathak07 reviewed Jan 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/benchmark/benchmark.js Outdated
Comment on lines 67 to 68
x = ( randu() * 100.0 ) + EPS;
y = skewness( k, lambda );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't understand why you are setting values for x but inside function skewness you are passing the parameters k and lambda

Neerajpathak07
Neerajpathak07 reviewed Jan 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/benchmark/benchmark.native.js Outdated
Comment on lines 54 to 55
k[ i ] = ( randu() * 10.0 ) + 1.0; // shape parameter > 0
lambda[ i ] = ( randu() * 10.0 ) + 1.0; // scale parameter > 0
Copy link
Member

@Neerajpathak07 Neerajpathak07 Jan 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to use uniform function to generate the parameters for added clarity as you did in benchmark.c

Suggested change
k[ i ] = ( randu() * 10.0 ) + 1.0; // shape parameter > 0
lambda[ i ] = ( randu() * 10.0 ) + 1.0; // scale parameter > 0
k[ i ] = uniform( 1.0, 10.0 ); // shape parameter > 0
lambda[ i ] = uniform( 1.0, 10.0 ); // scale parameter > 0

Neerajpathak07
Neerajpathak07 reviewed Jan 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/examples/c/example.c
Comment on lines +35 to +39
k = random_uniform( 1.0, 10.0 );

lambda = random_uniform( 1.0, 10.0 );

y = stdlib_base_dists_weibull_skewness( k, lambda );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
k = random_uniform( 1.0, 10.0 );
lambda = random_uniform( 1.0, 10.0 );
y = stdlib_base_dists_weibull_skewness( k, lambda );
k = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
lambda = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
y = stdlib_base_dists_weibull_skewness( k, lambda );

Neerajpathak07
Neerajpathak07 reviewed Jan 19, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/weibull/skewness/benchmark/benchmark.native.js Outdated

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = skewness( k[ i % len ], lambda[ i % len ] );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
y = skewness( k[ i % len ], lambda[ i % len ] );
y = skewness( k[ i % 100 ], lambda[ i % 100 ] );

@Neerajpathak07
Copy link
Member

@yuvi-mittal The reason majority of your test cases are failing is because the test.native.js file is incorrect. You don't have to change the code explicitly use the code from test.js and add opts parameter to create its native version also remember to remove the var skewness and wrap it with tryRequire and resolve functions

@yuvi-mittal
change in addon.c
e4070f4 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 21, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/weibull/skewness $\color{green}209/209$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}209/209$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@yuvi-mittal
add test in tesi.native.js
2b1f3b1 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@yuvi-mittal
Copy link
Contributor Author

@kgryte , this PR looks ready to merge to me .

@yuvi-mittal yuvi-mittal changed the title feat:C implementation of stats/base/dists/weibull/skewness feat:C implementation of stats/base/dists/weibull/skewness Apr 3, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 3, 2025
@yuvi-mittal yuvi-mittal changed the title feat:C implementation of stats/base/dists/weibull/skewness feat:add C implementation of stats/base/dists/weibull/skewness May 13, 2025
@yuvi-mittal yuvi-mittal changed the title feat:add C implementation of stats/base/dists/weibull/skewness feat: add C implementation of stats/base/dists/weibull/skewness Jun 22, 2025
@Planeshifter
Copy link
Member

This was resolved in #4053, so closing this PR. Thanks for your efforts!

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/weibull/skewness
5 participants
@yuvi-mittal @DhruvArvindSingh @Neerajpathak07 @stdlib-bot @Planeshifter