Skip to content

bench: refactor random number generation in stats/base/dists/bernoulli #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2025
Merged

bench: refactor random number generation in stats/base/dists/bernoulli #4775

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40aae66
refactor: random number generation in JS benchmarks for stats/base/di…
anandkaranubc Jan 16, 2025
3aea2d6
Apply suggestions from code review
kgryte Jan 16, 2025
d6c9084
refactor: improve random number generation in JS benchmarks for stats…
anandkaranubc Jan 18, 2025
2edc25b
Merge branch 'bernoulli-benchmarks' of https://github.com/anandkaranu…
anandkaranubc Jan 18, 2025
f2ab87a
bench: move random number generation outside the benchmarking loops
anandkaranubc Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var cdf = require( './../lib' );
Expand All @@ -37,8 +37,8 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*3.0 ) - 1.0;
p = randu();
x = uniform( -1.0, 2.0 );
p = uniform( 0.0, 1.0 );
y = cdf( x, p );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -64,7 +64,7 @@ bench( pkg+':factory', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*3.0 ) - 1.0;
x = uniform( -1.0, 2.0 );
y = mycdf( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
30 changes: 15 additions & 15 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/ctor/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var round = require( '@stdlib/math/base/special/round' );
var uniform = require( '@stdlib/random/base/uniform' );
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var ln = require( '@stdlib/math/base/special/ln' );
var pkg = require( './../package.json' ).name;
Expand All @@ -38,7 +38,7 @@ bench( pkg+'::instantiation', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
p = randu();
p = uniform( 0.0, 1.0 );
dist = new Bernoulli( p );
if ( !( dist instanceof Bernoulli ) ) {
b.fail( 'should return a distribution instance' );
Expand Down Expand Up @@ -87,7 +87,7 @@ bench( pkg+'::set:p', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = randu();
y = uniform( 0.0, 1.0 );
dist.p = y;
if ( dist.p !== y ) {
b.fail( 'should return set value' );
Expand All @@ -112,7 +112,7 @@ bench( pkg+':entropy', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.p = randu();
dist.p = uniform( 0.0, 1.0 );
y = dist.entropy;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -137,7 +137,7 @@ bench( pkg+':kurtosis', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.p = randu();
dist.p = uniform( 0.0, 1.0 );
y = dist.kurtosis;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -162,7 +162,7 @@ bench( pkg+':mean', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.p = randu();
dist.p = uniform( 0.0, 1.0 );
y = dist.mean;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -187,7 +187,7 @@ bench( pkg+':median', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.p = randu();
dist.p = uniform( 0.0, 1.0 );
y = dist.median;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -212,7 +212,7 @@ bench( pkg+':skewness', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.p = randu();
dist.p = uniform( 0.0, 1.0 );
y = dist.skewness;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -237,7 +237,7 @@ bench( pkg+':stdev', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.p = randu();
dist.p = uniform( 0.0, 1.0 );
y = dist.stdev;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -262,7 +262,7 @@ bench( pkg+':variance', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.p = randu();
dist.p = uniform( 0.0, 1.0 );
y = dist.variance;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -288,7 +288,7 @@ bench( pkg+':cdf', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu() * 6.0;
x = uniform( 0.0, 6.0 );
y = dist.cdf( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -314,7 +314,7 @@ bench( pkg+':mgf', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu() * ( -ln( 1.0-p ) );
x = uniform( 0.0, -ln( 1.0-p ) );
y = dist.mgf( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -340,7 +340,7 @@ bench( pkg+':pmf', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = round( randu() * 8.0 );
x = discreteUniform( 0, 8 );
y = dist.pmf( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -366,7 +366,7 @@ bench( pkg+':quantile', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu();
x = uniform( 0.0, 1.0 );
y = dist.quantile( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/entropy/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var entropy = require( './../lib' );
Expand All @@ -39,7 +39,7 @@ bench( pkg, function benchmark( b ) {
len = 100;
p = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
p[ i ] = randu();
p[ i ] = uniform( 0.0, 1.0 );
}

b.tic();
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/kurtosis/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var kurtosis = require( './../lib' );
Expand All @@ -36,7 +36,7 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
p = randu();
p = uniform( 0.0, 1.0 );
y = kurtosis( p );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/mean/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -40,7 +40,7 @@ bench( pkg, function benchmark( b ) {
len = 100;
p = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
p[ i ] = ( randu()*1.0 ) + EPS;
p[ i ] = uniform( EPS, 1.0 );
}

b.tic();
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/mean/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var EPS = require( '@stdlib/constants/float64/eps' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var tryRequire = require( '@stdlib/utils/try-require' );
Expand All @@ -49,7 +49,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
len = 100;
p = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
p[ i ] = ( randu()*1.0 ) + EPS;
p[ i ] = uniform( EPS, 1.0 );
}

b.tic();
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/median/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var median = require( './../lib' );
Expand All @@ -36,7 +36,7 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
p = randu();
p = uniform( 0.0, 1.0 );
y = median( p );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
8 changes: 4 additions & 4 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/mgf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var mgf = require( './../lib' );
Expand All @@ -37,8 +37,8 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
p = randu();
t = randu() * 3.0;
p = uniform( 0.0, 1.0 );
t = uniform( 0.0, 3.0 );
y = mgf( t, p );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -64,7 +64,7 @@ bench( pkg+':factory', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
t = randu() * 3.0;
t = uniform( 0.0, 3.0 );
y = mymgf( t );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/mode/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var mode = require( './../lib' );
Expand All @@ -39,7 +39,7 @@ bench( pkg, function benchmark( b ) {
len = 100;
p = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
p[ i ] = randu();
p[ i ] = uniform( 0.0, 1.0 );
}

b.tic();
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/mode/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var tryRequire = require( '@stdlib/utils/try-require' );
var pkg = require( './../package.json' ).name;
Expand All @@ -48,7 +48,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
len = 100;
p = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
p[ i ] = randu();
p[ i ] = uniform( 0.0, 1.0 );
}

b.tic();
Expand Down
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/pmf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var round = require( '@stdlib/math/base/special/round' );
var uniform = require( '@stdlib/random/base/uniform' );
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var pmf = require( './../lib' );
Expand All @@ -38,8 +38,8 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = round( randu()*3.0 );
p = randu();
x = discreteUniform( 0, 3 );
p = uniform( 0.0, 1.0 );
y = pmf( x, p );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -65,7 +65,7 @@ bench( pkg+':factory', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu() * 3.0;
x = uniform( 0.0, 3.0 );
y = mypmf( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
8 changes: 4 additions & 4 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var quantile = require( './../lib' );
Expand All @@ -37,8 +37,8 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
r = randu();
p = randu();
r = uniform( 0.0, 1.0 );
p = uniform( 0.0, 1.0 );
y = quantile( r, p );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -64,7 +64,7 @@ bench( pkg+':factory', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
r = randu();
r = uniform( 0.0, 1.0 );
y = myquantile( r );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/bernoulli/skewness/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var skewness = require( './../lib' );
Expand All @@ -36,7 +36,7 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
p = randu();
p = uniform( 0.0, 1.0 );
y = skewness( p );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
Loading
Loading