Skip to content

bench: refactor random number generation in stats/base/dists/cauchy #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

bench: refactor random number generation in stats/base/dists/cauchy #4850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07185a2
bench: move random number generation outside the benchmarking loops
anandkaranubc Jan 22, 2025
9e06b83
Merge branch 'stdlib-js:develop' into cauchy-benchmarks
anandkaranubc Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions lib/node_modules/@stdlib/stats/base/dists/cauchy/cdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -32,17 +33,25 @@ var cdf = require( './../lib' );

bench( pkg, function benchmark( b ) {
var gamma;
var len;
var x0;
var x;
var y;
var i;

len = 100;
x = new Float64Array( len );
x0 = new Float64Array( len );
gamma = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( -100.0, 100.0 );
x0[ i ] = uniform( -50.0, 50.0 );
gamma[ i ] = uniform( EPS, 20.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*200.0 ) - 100;
x0 = ( randu()*100.0 ) - 50.0;
gamma = ( randu()*20.0 ) + EPS;
y = cdf( x, x0, gamma );
y = cdf( x[ i % len ], x0[ i % len ], gamma[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -58,6 +67,7 @@ bench( pkg, function benchmark( b ) {
bench( pkg+':factory', function benchmark( b ) {
var mycdf;
var gamma;
var len;
var x0;
var x;
var y;
Expand All @@ -66,11 +76,15 @@ bench( pkg+':factory', function benchmark( b ) {
x0 = 0.0;
gamma = 1.5;
mycdf = cdf.factory( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*100.0 ) + EPS;
y = mycdf( x );
y = mycdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
110 changes: 87 additions & 23 deletions lib/node_modules/@stdlib/stats/base/dists/cauchy/ctor/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -33,14 +34,21 @@ var Cauchy = require( './../lib' );
bench( pkg+'::instantiation', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var i;

len = 100;
x0 = new Float64Array( len );
gamma = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x0[ i ] = uniform( EPS, 10.0 );
gamma[ i ] = uniform( EPS, 10.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x0 = ( randu() * 10.0 ) + EPS;
gamma = ( randu() * 10.0 ) + EPS;
dist = new Cauchy( x0, gamma );
dist = new Cauchy( x0[ i % len ], gamma[ i % len ] );
if ( !( dist instanceof Cauchy ) ) {
b.fail( 'should return a distribution instance' );
}
Expand Down Expand Up @@ -82,19 +90,24 @@ bench( pkg+'::get:x0', function benchmark( b ) {
bench( pkg+'::set:x0', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var y;
var i;

x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
y = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
y[ i ] = uniform( EPS, 100.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = ( 100.0*randu() ) + EPS;
dist.x0 = y;
if ( dist.x0 !== y ) {
dist.x0 = y[ i % len ];
if ( dist.x0 !== y[ i % len ] ) {
b.fail( 'should return set value' );
}
}
Expand Down Expand Up @@ -135,19 +148,24 @@ bench( pkg+'::get:gamma', function benchmark( b ) {
bench( pkg+'::set:gamma', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var y;
var i;

x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
y = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
y[ i ] = uniform( EPS, 100.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = ( 100.0*randu() ) + EPS;
dist.gamma = y;
if ( dist.gamma !== y ) {
dist.gamma = y[ i % len ];
if ( dist.gamma !== y[ i % len ] ) {
b.fail( 'should return set value' );
}
}
Expand All @@ -162,17 +180,24 @@ bench( pkg+'::set:gamma', function benchmark( b ) {
bench( pkg+':entropy', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var x;
var y;
var i;

x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.x0 = ( 100.0*randu() ) + EPS;
dist.x0 = x[ i % len ];
y = dist.entropy;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -189,17 +214,24 @@ bench( pkg+':entropy', function benchmark( b ) {
bench( pkg+':median', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var x;
var y;
var i;

x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( EPS, 100.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.x0 = ( 100.0*randu() ) + EPS;
dist.x0 = x[ i % len ];
y = dist.median;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -216,17 +248,24 @@ bench( pkg+':median', function benchmark( b ) {
bench( pkg+':mode', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var x;
var y;
var i;

x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( 1.0 + EPS, 100.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
dist.x0 = ( 100.0*randu() ) + 1.0 + EPS;
dist.x0 = x[ i % len ];
y = dist.mode;
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand All @@ -243,6 +282,7 @@ bench( pkg+':mode', function benchmark( b ) {
bench( pkg+':cdf', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var x;
var y;
Expand All @@ -251,11 +291,15 @@ bench( pkg+':cdf', function benchmark( b ) {
x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( 0.0, 1.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu();
y = dist.cdf( x );
y = dist.cdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -271,6 +315,7 @@ bench( pkg+':cdf', function benchmark( b ) {
bench( pkg+':logcdf', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var x;
var y;
Expand All @@ -279,11 +324,15 @@ bench( pkg+':logcdf', function benchmark( b ) {
x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( 0.0, 1.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu();
y = dist.logcdf( x );
y = dist.logcdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -299,6 +348,7 @@ bench( pkg+':logcdf', function benchmark( b ) {
bench( pkg+':logpdf', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var x;
var y;
Expand All @@ -307,11 +357,15 @@ bench( pkg+':logpdf', function benchmark( b ) {
x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( 0.0, 1.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu();
y = dist.logpdf( x );
y = dist.logpdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -327,6 +381,7 @@ bench( pkg+':logpdf', function benchmark( b ) {
bench( pkg+':pdf', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var x;
var y;
Expand All @@ -335,11 +390,15 @@ bench( pkg+':pdf', function benchmark( b ) {
x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( 0.0, 1.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu();
y = dist.pdf( x );
y = dist.pdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -355,6 +414,7 @@ bench( pkg+':pdf', function benchmark( b ) {
bench( pkg+':quantile', function benchmark( b ) {
var gamma;
var dist;
var len;
var x0;
var x;
var y;
Expand All @@ -363,11 +423,15 @@ bench( pkg+':quantile', function benchmark( b ) {
x0 = 10.0;
gamma = 6.0;
dist = new Cauchy( x0, gamma );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( 0.0, 1.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = randu();
y = dist.quantile( x );
y = dist.quantile( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/cauchy/entropy/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -42,8 +42,8 @@ bench( pkg, function benchmark( b ) {
gamma = new Float64Array( len );
x0 = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x0[ i ] = ( randu()*100.0 ) - 50.0;
gamma[ i ] = ( randu()*20.0 ) + EPS;
x0[ i ] = uniform( -50.0, 50.0 );
gamma[ i ] = uniform( EPS, 20.0 );
}

b.tic();
Expand Down
Loading
Loading