Skip to content

fix: catch unexpected errors from acorn-loose in REPL tokenizer #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix: catch unexpected errors from acorn-loose in REPL tokenizer #4956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/node_modules/@stdlib/repl/lib/tokenizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,15 @@
var i;

// Parse the given line into tokens & comments...
ast = parse( line, {
'ecmaVersion': 'latest',
'onToken': onToken,
'onComment': onComment
});
try {
ast = parse( line, {
'ecmaVersion': 'latest',
'onToken': onToken,
'onComment': onComment
});
} catch ( error ) { // eslint-disable-line no-unused-vars
return tokens;
}

// Resolve variable declarations from the given line as tokens...
declarations = resolveLocalScopes( ast );
Expand Down Expand Up @@ -174,7 +178,7 @@
*/
function onComment( block, text, start, end ) {
if ( block ) {
// TODO: add support for highlighting multi-line comments.

Check warning on line 181 in lib/node_modules/@stdlib/repl/lib/tokenizer.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: add support for highlighting...'
return;
}
tokens.push({
Expand Down
Loading