Skip to content

Conversation

vivekmaurya001
Copy link
Contributor

@vivekmaurya001 vivekmaurya001 commented Feb 2, 2025

Description

  • refactors JS implementation for @stdlib/stats/base/cumax along with benchmarks and examples to follow latest conventions
  • used defined ndarray function instead of defining a new function
  • updated the readme file , package.json , benchmark.c , examples.c

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 2, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 2, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/cumax $\color{green}244/244$
$\color{green}+100.00\%$
$\color{green}20/20$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}244/244$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001 vivekmaurya001 marked this pull request as draft February 2, 2025 10:25
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 2, 2025
@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review February 2, 2025 10:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 2, 2025
@vivekmaurya001
Copy link
Contributor Author

vivekmaurya001 commented Feb 2, 2025

@Planeshifter, @gunjjoshi , @kgryte please take a look

@vivekmaurya001 vivekmaurya001 deleted the stat/base/cumax branch February 21, 2025 16:35
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants