feat: add C ndarray API and refactor `blas/ext/base/ssort2ins` #5114

0PrashantYadav0 · 2025-02-08T11:51:46Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: na
task: lint_package_json status: na
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: na
task: lint_javascript_benchmarks status: na
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: passed
task: lint_c_examples status: passed
task: lint_c_benchmarks status: passed
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: na
task: lint_license_headers status: passed ---

type: pre_push_report
description: Results of running various checks prior to pushing changes. report:

task: run_javascript_examples status: na
task: run_c_examples status: na
task: run_cpp_examples status: na
task: run_javascript_readme_examples status: na
task: run_c_benchmarks status: na
task: run_cpp_benchmarks status: na
task: run_fortran_benchmarks status: na
task: run_javascript_benchmarks status: na
task: run_julia_benchmarks status: na
task: run_python_benchmarks status: na
task: run_r_benchmarks status: na
task: run_javascript_tests status: na ---

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

add C ndarray API and refactor/cleanup blas/ext/base/ssort2ins

Related Issues

Does this pull request have any related issues?

This pull request:

resolves None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-02-08T11:53:05Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/ssort2ins	$\color{green}521/521$ $\color{green}+100.00\%$	$\color{green}41/41$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}521/521$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

headlessNode

Thanks for working on this. In addition to these suggestions you also need to update the line 100 in the repl. It should be same as in the README.md

lib/node_modules/@stdlib/blas/ext/base/ssort2ins/README.md

lib/node_modules/@stdlib/blas/ext/base/ssort2ins/src/main.c

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

0PrashantYadav0 · 2025-02-08T15:48:34Z

Thank you @headlessNode for review. I made the changes you asked for. Please review again.

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode

Just found out, our convention is to NOT add spacing around parens when casting. This applies to other similar PRs as well.

lib/node_modules/@stdlib/blas/ext/base/ssort2ins/benchmark/c/benchmark.unsorted_random.length.c

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/blas/ext/base/ssort2ins/README.md

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode · 2025-02-10T09:41:08Z

LGTM.

0PrashantYadav0 · 2025-02-10T09:58:45Z

Thanks for approval.

0PrashantYadav0 · 2025-02-10T18:57:40Z

@kgryte Please review and merge this pr. Thank you.

stdlib-bot · 2025-02-11T01:24:45Z

PR Commit Message

feat: add C ndarray API and refactor `blas/ext/base/ssort2ins`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5114

Co-authored-by: Muhammad Haris <[email protected]>
Reviewed-by: Muhammad Haris <[email protected]>
Signed-off-by: Muhammad Haris <[email protected]>

Please review the above commit message and make any necessary adjustments.

PR-URL: stdlib-js#5114 Co-authored-by: Muhammad Haris <[email protected]> Reviewed-by: Muhammad Haris <[email protected]> Signed-off-by: Muhammad Haris <[email protected]>

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Feb 8, 2025

headlessNode reviewed Feb 8, 2025

View reviewed changes

headlessNode added the Feature Issue or pull request for adding a new feature. label Feb 8, 2025

0PrashantYadav0 requested a review from headlessNode February 8, 2025 15:48

docs: update offset description

8558918

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode requested changes Feb 8, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/ssort2ins/benchmark/c/benchmark.unsorted_random.length.c Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/blas/ext/base/ssort2ins/benchmark/c/benchmark.unsorted_random.length.c Outdated Show resolved Hide resolved

headlessNode added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 8, 2025

0PrashantYadav0 requested a review from headlessNode February 10, 2025 04:37

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 10, 2025

headlessNode removed the Needs Changes Pull request which needs changes before being merged. label Feb 10, 2025

headlessNode reviewed Feb 10, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/ssort2ins/README.md Outdated Show resolved Hide resolved

docs: apply suggestions from code review

2be46c0

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode approved these changes Feb 10, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 11, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 11, 2025

Planeshifter merged commit 8357863 into stdlib-js:develop Feb 11, 2025
28 checks passed

Uh oh!

feat: add C ndarray API and refactor blas/ext/base/ssort2ins #5114

feat: add C ndarray API and refactor blas/ext/base/ssort2ins #5114

Uh oh!

Conversation

0PrashantYadav0 commented Feb 8, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

headlessNode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0PrashantYadav0 commented Feb 8, 2025

Uh oh!

headlessNode left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Feb 10, 2025

Uh oh!

0PrashantYadav0 commented Feb 10, 2025

Uh oh!

0PrashantYadav0 commented Feb 10, 2025

Uh oh!

stdlib-bot commented Feb 11, 2025

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add C ndarray API and refactor `blas/ext/base/ssort2ins` #5114

feat: add C ndarray API and refactor `blas/ext/base/ssort2ins` #5114

stdlib-bot commented Feb 8, 2025 •

edited

Loading

headlessNode left a comment •

edited

Loading