bench: refactor random number generation in JS benchmarks for stats/b… #5162

yaswanthkosuru · 2025-02-10T05:53:17Z

Resolves #4982.

Description

What is the purpose of this pull request?

This pull request:

Refactor random number generation in JS benchmarks for stats/base/dists/pareto-type1

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/pareto-type1 #4982

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

…ase/dists/pareto-type1 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-02-10T05:55:58Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/pareto-type1/cdf	$\color{green}239/239$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}239/239$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/ctor	$\color{green}438/438$ $\color{green}+100.00\%$	$\color{green}32/32$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}438/438$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/entropy	$\color{green}126/126$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}126/126$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/kurtosis	$\color{green}128/128$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}128/128$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/logcdf	$\color{green}243/243$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}243/243$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/logpdf	$\color{green}251/251$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}251/251$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/mean	$\color{green}122/122$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}122/122$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/median	$\color{green}119/119$ $\color{green}+100.00\%$	$\color{green}6/6$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}119/119$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/mode	$\color{green}124/124$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}124/124$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/pdf	$\color{green}251/251$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}251/251$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/quantile	$\color{green}235/235$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}235/235$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/skewness	$\color{green}196/196$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}196/196$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/stdev	$\color{green}203/203$ $\color{green}+100.00\%$	$\color{green}12/12$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}203/203$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/variance	$\color{green}129/129$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}129/129$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

yaswanthkosuru · 2025-02-10T05:56:43Z

@Planeshifter ready for review

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/cdf/benchmark/benchmark.js

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/ctor/benchmark/benchmark.js

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/mode/benchmark/benchmark.js

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/skewness/benchmark/benchmark.js

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/stdev/benchmark/benchmark.js

anandkaranubc · 2025-02-10T07:45:56Z

Great work, @yaswanthkosuru. Just some minor changes, otherwise the PR looks good!

…stats/base/dists/pareto-type1 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

yaswanthkosuru · 2025-02-10T09:36:50Z

@anandkaranubc addressed all changes can you please review.hoping no changes required more.
does make lint doesnt add gaps (ex:like gap between =,small gap after operators ). is there Any other way to do these?

anandkaranubc

There still are some changes that are yet to be made based on the review.

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/stdev/benchmark/benchmark.js

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/skewness/benchmark/benchmark.native.js

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/skewness/benchmark/benchmark.js

anandkaranubc · 2025-02-10T18:04:22Z

is there Any other way to do these?

Yes, you can call the bot for lint fixes, but relying on it isn't a good practice.

Signed-off-by: yaswanth <[email protected]>

anandkaranubc · 2025-02-12T23:45:31Z

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/ctor/benchmark/benchmark.js

 	alpha = 100.56789;
 	beta = 55.54321;
 	dist = new Pareto1( alpha, beta );
+	len=100;


Suggested change

len=100;

len = 100;

anandkaranubc · 2025-02-12T23:45:52Z

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/ctor/benchmark/benchmark.js

+	len = 100;
+	x = new Float64Array( len );
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( EPS, 100.0 );


Is EPS needed here?

anandkaranubc · 2025-02-12T23:47:27Z

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/ctor/benchmark/benchmark.js

+	len = 100;
+	x = new Float64Array( len );
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( EPS, 100.0 );


Suggested change

x[ i ] = uniform( EPS, 100.0 );

x[ i ] = uniform( 0.0, 100.0 );

Same comment as above. If EPS is necessary here, it's fine to keep it. Otherwise, the range should remain the same as original.

anandkaranubc · 2025-02-12T23:48:30Z

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/logcdf/benchmark/benchmark.js


 	alpha = 100.56789;
 	beta = 55.54321;
+	len=100;


Suggested change

len=100;

len = 100;

anandkaranubc · 2025-02-12T23:48:46Z

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/logcdf/benchmark/benchmark.js

 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu()*50.0 ) + EPS;
-		y = mylogcdf( x );
+		y = mylogcdf( x[ i % len] );


Suggested change

y = mylogcdf( x[ i % len] );

y = mylogcdf( x[ i % len ] );

anandkaranubc · 2025-02-12T23:51:28Z

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/pdf/benchmark/benchmark.js

 	alpha = 100.56789;
 	beta = 55.54321;
+	len=100;
+	x = new Float64Array( len );
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( EPS, 50.0 );
+	}
 	mypdf = pdf.factory( alpha, beta );


Suggested change

alpha = 100.56789;

beta = 55.54321;

len=100;

x = new Float64Array( len );

for ( i = 0; i < len; i++ ) {

x[ i ] = uniform( EPS, 50.0 );

}

mypdf = pdf.factory( alpha, beta );

alpha = 100.56789;

beta = 55.54321;

mypdf = pdf.factory( alpha, beta );

len = 100;

x = new Float64Array( len );

for ( i = 0; i < len; i++ ) {

x[ i ] = uniform( EPS, 50.0 );

}

anandkaranubc · 2025-02-12T23:52:11Z

lib/node_modules/@stdlib/stats/base/dists/pareto-type1/quantile/benchmark/benchmark.js

+	}
 	b.tic();


Suggested change

}

b.tic();

}

b.tic();

stdlib-bot · 2025-06-22T23:32:43Z

Thank you for working on this pull request. However, we cannot accept your contribution due to Git history issues.

Some common issues include:

Merge conflicts
Inappropriate commit messages
Unrelated commits
Including changes from merged branches that weren't intended for this PR

We recommend opening a new pull request with only the intended changes.

Thank you for your interest in stdlib, and we look forward to your future contributions.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 10, 2025

anandkaranubc requested changes Feb 10, 2025

View reviewed changes

anandkaranubc added the Needs Changes Pull request which needs changes before being merged. label Feb 10, 2025

anandkaranubc requested changes Feb 10, 2025

View reviewed changes

chore:Update benchmark.js

7b36816

Signed-off-by: yaswanth <[email protected]>

anandkaranubc requested changes Feb 12, 2025

View reviewed changes

Planeshifter added the autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. label Jun 22, 2025

stdlib-bot closed this Jun 22, 2025

stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed Needs Review A pull request which needs code review. labels Jun 22, 2025

	x[ i ] = uniform( EPS, 100.0 );
	x[ i ] = uniform( 0.0, 100.0 );

Uh oh!

bench: refactor random number generation in JS benchmarks for stats/b… #5162

bench: refactor random number generation in JS benchmarks for stats/b… #5162

Uh oh!

Conversation

yaswanthkosuru commented Feb 10, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

yaswanthkosuru commented Feb 10, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anandkaranubc commented Feb 10, 2025

Uh oh!

yaswanthkosuru commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anandkaranubc commented Feb 10, 2025

Uh oh!

anandkaranubc Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jun 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stdlib-bot commented Feb 10, 2025 •

edited

Loading

yaswanthkosuru commented Feb 10, 2025 •

edited

Loading