Skip to content

feat: add strided and assign APIs to complex/float32/base/add #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

feat: add strided and assign APIs to complex/float32/base/add #5197

wants to merge 19 commits into from

Conversation

ShabiShett07
Copy link
Contributor

Resolves #5196

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Feb 11, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 11, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
complex/float32/base/add $\color{green}302/302$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}302/302$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Feb 16, 2025
@kgryte kgryte changed the title feat: add strided and assign support for /complex/float32/base/add feat: add strided and assign APIs to complex/float32/base/add Feb 16, 2025
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Feb 16, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 19, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 19, 2025
@ShabiShett07
Copy link
Contributor Author

@Neerajpathak07 could you help me out with the CI errors?

@Neerajpathak07
Copy link
Member 

Error: Cannot find module '@stdlib/assert/is-same-Float32Array'

  • For starters checkout if this latter exists in the repo or not.

  • For Lint errors most of them are based on needing a newline at the end of the file. The details should provide a brief overview to it.

@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Feb 19, 2025 •
edited
Loading

@ShabiShett07 ahh understood where the problem should lie so the latter does exist but it appears you have made a typo the correct module should be :- @stdlib/assert/is-same-float32array
This should resolve the error. LMK if it still persists.

@ShabiShett07
fix: update test.assign.js
4d5b8f9 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: update test.assign.js
b1de61d 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: update test.strided.js
6de0449 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

Thank you @Neerajpathak07, this solved my error.

@ShabiShett07 ShabiShett07 marked this pull request as ready for review February 20, 2025 07:02
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 20, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 20, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 20, 2025
kgryte
kgryte reviewed Feb 22, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 22, 2025
View reviewed changes
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 22, 2025
ShabiShett07 and others added 2 commits February 22, 2025 18:40
@ShabiShett07
fix: rename benchmark.assign.js
36986fd 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: updated file permissions
87e75b3 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
Copy link
Contributor Author

Sorry @kgryte sir for such inconvenience, I have made the necessary changes. Please check

@ShabiShett07
fix: updated file permissions
f6d17f3 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: passed
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: passed
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@ShabiShett07
fix: updated file permissions
d22cd19 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@ShabiShett07
Copy link
Contributor Author

Sorry @kgryte, I think this PR still needs some changes I will notify once it is done

@ShabiShett07 ShabiShett07 marked this pull request as draft February 22, 2025 16:08
@ShabiShett07
Copy link
Contributor Author

@kgryte, Closed this issue because it has lot of errors and opened a new one #5391 which is ready for review

@ShabiShett07 ShabiShett07 deleted the feature/float32/add branch April 3, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

+1 more reviewer

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add strided and assign support for complex/float32/base/add
4 participants
@ShabiShett07 @stdlib-bot @Neerajpathak07 @kgryte