Skip to content

feat: add strided and assign APIs to complex/float32/base/mul #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 16, 2025
Merged

feat: add strided and assign APIs to complex/float32/base/mul #5205

merged 5 commits into from
Feb 16, 2025

Conversation

ShabiShett07
Copy link
Contributor

@ShabiShett07 ShabiShett07 commented Feb 12, 2025 •
edited
Loading

Resolves #5203

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 12, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 12, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 12, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
complex/float32/base/mul $\color{green}321/321$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}321/321$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Feb 16, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 16, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 16, 2025
@kgryte kgryte changed the title feat: add strided and assign support for /complex/float32/base/mul feat: add strided and assign support for complex/float32/base/mul Feb 16, 2025
kgryte
kgryte reviewed Feb 16, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 16, 2025
View reviewed changes
kgryte
kgryte reviewed Feb 16, 2025
View reviewed changes
kgryte
kgryte approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Feb 16, 2025
@kgryte kgryte changed the title feat: add strided and assign support for complex/float32/base/mul feat: add strided and assign APIs to complex/float32/base/mul Feb 16, 2025
@kgryte kgryte merged commit d7154e2 into stdlib-js:develop Feb 16, 2025
29 checks passed
@ShabiShett07 ShabiShett07 deleted the feature/mul branch February 16, 2025 08:40
ShabiShett07 added a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@ShabiShett07 @kgryte @stdlib-bot
feat: add strided and assign APIs to complex/float32/base/mul
e223021 
PR-URL: stdlib-js#5205
Closes: stdlib-js#5203
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. First-time Contributor A pull request from a contributor who has never previously committed to the project repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add strided and assign support for complex/float32/base/mul

3 participants

@ShabiShett07 @stdlib-bot @kgryte