Skip to content

Conversation

rishavtarway
Copy link
Contributor

@rishavtarway rishavtarway commented Feb 18, 2025

Resolves #5229.

Description

What is the purpose of this pull request?

This pull request:address the commit comments of (commit 120e678)

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

Hi, reviewers! Could you please check if I have followed the contributing guidelines properly? If there are any mistakes or areas for improvement in my code or approach, I would appreciate your feedback. I'm open to suggestions for making it better!

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 18, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/planck/stdev $\color{green}166/166$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}166/166$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@rishavtarway
Copy link
Contributor Author

@kgryte can you review this PR once ?

@kgryte kgryte changed the title Chore : Address Commit Comments Regarding mathematical and technical Justification chore : address commit comments Feb 19, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your first contribution, @rishavtarway!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Feb 19, 2025
@kgryte kgryte changed the title chore : address commit comments chore: address commit comments Feb 19, 2025
@kgryte
Copy link
Member

kgryte commented Feb 19, 2025

The lint errors have been addressed. As such, I will go ahead and merge.

@kgryte kgryte merged commit eecbeee into stdlib-js:develop Feb 19, 2025
62 of 64 checks passed
@rishavtarway rishavtarway deleted the fix/#5229 branch February 19, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 120e678)

3 participants