-
-
Notifications
You must be signed in to change notification settings - Fork 995
Fix : Address multiple commit comments(#5233, #5231, #5230, #5229, #5227) #5284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@suhaib-ilahi Would you mind splitting these into separate PRs? As you may notice, some of the commit comment issues have been addressed by other PRs and there are now merge conflicts. |
|
I will make the new PRs since some of the issue is addressed |
Resolves -:
#5233
#5231
#5230
#5229
#5227
Description
This pull request:
resolves the different issues. Address the comments of the commits.
Related Issues
None
This pull request:
Address commit comments (commit
ac38037) #5233Address commit comments (commit
f0a9789) #5231Address commit comments (commit
8171728) #5230Address commit comments (commit
120e678) #5229Address commit comments (commit
44c266e) #5227Questions
Hey reviewers !
Please check if i had done all the things correct and following the contributing and style guides correctly.
Other
No.
Checklist
@stdlib-js/reviewers