Skip to content

Conversation

suhaib-ilahi
Copy link
Contributor

@suhaib-ilahi suhaib-ilahi commented Feb 18, 2025

Resolves -:
#5233
#5231
#5230
#5229
#5227

Description

What is the purpose of this pull request?

This pull request:
resolves the different issues. Address the comments of the commits.

Related Issues

Does this pull request have any related issues?

None

This pull request:

Questions

Any questions for reviewers of this pull request?

Hey reviewers !
Please check if i had done all the things correct and following the contributing and style guides correctly.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Feb 18, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/exponential/entropy $\color{green}162/162$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}162/162$
$\color{green}+100.00\%$
stats/base/dists/exponential/quantile $\color{green}283/283$
$\color{green}+100.00\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}283/283$
$\color{green}+100.00\%$
stats/base/dists/planck/stdev $\color{green}165/165$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}165/165$
$\color{green}+100.00\%$
stats/base/dists/uniform/logpdf $\color{green}291/291$
$\color{green}+100.00\%$
$\color{green}25/25$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}291/291$
$\color{green}+100.00\%$
stats/base/dists/uniform/quantile $\color{green}291/291$
$\color{green}+100.00\%$
$\color{green}24/24$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}291/291$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@suhaib-ilahi suhaib-ilahi changed the title Chore: Address commit comments Fix : Address multiple commit comments(#5233, #5231, #5230, #5229, #5227) Feb 18, 2025
@suhaib-ilahi suhaib-ilahi marked this pull request as ready for review February 18, 2025 10:40
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 18, 2025
@kgryte
Copy link
Member

kgryte commented Feb 19, 2025

@suhaib-ilahi Would you mind splitting these into separate PRs? As you may notice, some of the commit comment issues have been addressed by other PRs and there are now merge conflicts.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 19, 2025
@suhaib-ilahi
Copy link
Contributor Author

I will make the new PRs since some of the issue is addressed

@suhaib-ilahi suhaib-ilahi deleted the fix/commitComments branch February 19, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants