Skip to content

Conversation

gkbishnoi07
Copy link
Contributor

Resolves #5347

Description

What is the purpose of this pull request?

This pull request:

  • fixing C lint error

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 21, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 21, 2025

Coverage Report

Package Statements Branches Functions Lines
number/float64/base/normalize $\color{green}313/313$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}313/313$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gkbishnoi07
Copy link
Contributor Author

@Planeshifter @kgryte please review this PRs

@gkbishnoi07
Copy link
Contributor Author

@kgryte will i remove this 3.14e308 to resolve this issue or search for other methods

@kgryte
Copy link
Member

kgryte commented Feb 22, 2025

@gkbishnoi07 Please don't marked conversations as resolved, if they are not resolved. I provided the two suggestions for you to apply to this PR. You should incorporate my suggested changes.

@gkbishnoi07
Copy link
Contributor Author

@gkbishnoi07 Please don't marked conversations as resolved, if they are not resolved. I provided the two suggestions for you to apply to this PR. You should incorporate my suggested changes.

@kgryte Understood! I'll make the suggested changes and update the PR accordingly. Thanks for your feedback!

@gkbishnoi07 gkbishnoi07 requested a review from kgryte February 22, 2025 00:19
@gkbishnoi07
Copy link
Contributor Author

@kgryte all issue resolved please review this PRs

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Feb 22, 2025
@kgryte kgryte merged commit 35df6a5 into stdlib-js:develop Feb 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

3 participants