Skip to content

Conversation

akash8843
Copy link

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request: fixes the missing opts argument in the test cases for the mgf function in the triangular distribution module. This change ensures that test cases run correctly with the required options.

Related Issues

Does this pull request have any related issues?

This pull request: Yes, this pull request resolves issue #5848.

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 7, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 7, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/geometric/cdf $\color{green}291/291$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}291/291$
$\color{green}+100.00\%$
stats/base/dists/triangular/mgf $\color{green}380/380$
$\color{green}+100.00\%$
$\color{green}38/38$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}380/380$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@akash8843
Copy link
Author

Hi @kgryte,

I hope you are doing well!

I have created a PR to fix added missing opts arguments in MGF test cases, I would really appreciate it if you could review my changes and provide feedback whenever you get a chance.

I’m excited to contribute to stdlib and would love to improve my PR based on your suggestions.

Thank you so much for your time and guidance!

Best regards,
Akash Shukla

@akash8843 akash8843 closed this Mar 7, 2025
@akash8843 akash8843 deleted the fix/missing-opts-arg branch March 7, 2025 16:36
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants