Skip to content

feat: refactor and add protocol support to stats/base/variancepn #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: refactor and add protocol support to stats/base/variancepn #5851

wants to merge 1 commit into from

Conversation

thefauxpastrouper
Copy link

@thefauxpastrouper thefauxpastrouper commented Mar 7, 2025 •
edited
Loading

Resolves #5689

Description

What is the purpose of this pull request?

  • Adds accessor arrays support.
  • Refactors stats/base/variancepn.

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Contributing guidelines

@stdlib-js/reviewers

@thefauxpastrouper
feat: refactor and add protocol support to stats/base/variancepn
877c47f 
- Adds accessor arrays support.
- Refactors `stats/base/variancepn`.

Does this pull request have any related issues?

- No

Any questions for reviewers of this pull request?

- No.

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

- No.

Please ensure the following tasks are completed before submitting this pull request.

- [ ] Read, understood, and followed the contributing guidelines.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 7, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 7, 2025
stdlib-bot
stdlib-bot reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/variancepn $\color{red}344/348$
$\color{green}+98.85\%$ 		$\color{red}20/22$
$\color{green}+90.91\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{red}344/348$
$\color{green}+98.85\%$

The above coverage report was generated for the changes in this PR.

@thefauxpastrouper thefauxpastrouper deleted the branch stdlib-js:develop March 7, 2025 10:59
@thefauxpastrouper thefauxpastrouper deleted the develop branch March 7, 2025 10:59
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 7, 2025
@thefauxpastrouper thefauxpastrouper restored the develop branch March 7, 2025 11:01
@thefauxpastrouper thefauxpastrouper deleted the develop branch March 7, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/variancepn

2 participants

@thefauxpastrouper @stdlib-bot