Skip to content

feat!: migrate math/base/ops/imuldw to number/int32/base/muldw #5886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2025
Merged

feat!: migrate math/base/ops/imuldw to number/int32/base/muldw #5886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fed0f06
feat: add `number/int32/base/muldw`
gururaj1512 Mar 8, 2025
87805a7
remove: remove `imuldw` from namespace
gururaj1512 Mar 8, 2025
c8d5e29
refactor: update paths
gururaj1512 Mar 8, 2025
9f90bef
remove: remove `math/base/ops/imuldw`
gururaj1512 Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/node_modules/@stdlib/math/base/ops/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ The namespace contains the following functions:
- <span class="signature">[`csub( z1, z2 )`][@stdlib/math/base/ops/csub]</span><span class="delimiter">: </span><span class="description">subtract two double-precision complex floating-point numbers.</span>
- <span class="signature">[`csubf( z1, z2 )`][@stdlib/math/base/ops/csubf]</span><span class="delimiter">: </span><span class="description">subtract two single-precision complex floating-point numbers.</span>
- <span class="signature">[`imul( a, b )`][@stdlib/number/int32/base/mul]</span><span class="delimiter">: </span><span class="description">perform C-like multiplication of two signed 32-bit integers.</span>
- <span class="signature">[`imuldw( a, b )`][@stdlib/math/base/ops/imuldw]</span><span class="delimiter">: </span><span class="description">compute the double word product of two signed 32-bit integers.</span>
- <span class="signature">[`imuldw( a, b )`][@stdlib/number/int32/base/muldw]</span><span class="delimiter">: </span><span class="description">compute the double word product of two signed 32-bit integers.</span>
- <span class="signature">[`umuldw( a, b )`][@stdlib/math/base/ops/umuldw]</span><span class="delimiter">: </span><span class="description">compute the double word product of two unsigned 32-bit integers.</span>

</div>
Expand Down Expand Up @@ -85,11 +85,6 @@ var z1 = new Complex128( 5.0, 3.0 );
var z2 = new Complex128( -2.0, 1.0 );
console.log( ns.cmul( z1, z2 ) ); // { 're': -13.0, 'im': -1.0 }
// => <Complex128>

// Operations for double word product:
// -(2^31) * 2^30 = -2305843009213694000 => 32-bit integer overflow
console.log( ns.imuldw( 0x80000000|0, 0x40000000|0 ) );
// => [ -536870912, 0 ]
```

</section>
Expand Down Expand Up @@ -122,7 +117,7 @@ console.log( ns.imuldw( 0x80000000|0, 0x40000000|0 ) );

[@stdlib/number/int32/base/mul]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/number/int32/base/mul

[@stdlib/math/base/ops/imuldw]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/ops/imuldw
[@stdlib/number/int32/base/muldw]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/number/int32/base/muldw

[@stdlib/math/base/ops/umuldw]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/ops/umuldw

Expand Down
18 changes: 0 additions & 18 deletions lib/node_modules/@stdlib/math/base/ops/docs/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import cneg = require( '@stdlib/math/base/ops/cneg' );
import cnegf = require( '@stdlib/math/base/ops/cnegf' );
import csub = require( '@stdlib/math/base/ops/csub' );
import csubf = require( '@stdlib/math/base/ops/csubf' );
import imuldw = require( '@stdlib/math/base/ops/imuldw' );
import umuldw = require( '@stdlib/math/base/ops/umuldw' );
import divf = require( '@stdlib/number/float32/base/div' );
import div = require( '@stdlib/number/float64/base/div' );
Expand Down Expand Up @@ -412,23 +411,6 @@ interface Namespace {
*/
csubf: typeof csubf;

/**
* Performs multiplication of two signed 32-bit integers and returns an array of two signed 32-bit integers which represents the signed 64-bit integer product.
*
* ## Notes
*
* - When computing the product of 32-bit integer values in double-precision floating-point format (the default JavaScript numeric data type), computing the double word product is necessary in order to avoid exceeding the maximum safe double-precision floating-point integer value.
*
* @param a - integer
* @param b - integer
* @returns output array
*
* @example
* var v = ns.imuldw( 0xAAAAAAAA, 0x55555555 );
* // returns [ -477218589, 1908874354 ]
*/
imuldw: typeof imuldw;

/**
* Performs multiplication of two unsigned 32-bit integers and returns an array of two unsigned 32-bit integers which represents the unsigned 64-bit integer product.
*
Expand Down
9 changes: 0 additions & 9 deletions lib/node_modules/@stdlib/math/base/ops/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,6 @@ setReadOnly( ns, 'csub', require( '@stdlib/math/base/ops/csub' ) );
*/
setReadOnly( ns, 'csubf', require( '@stdlib/math/base/ops/csubf' ) );

/**
* @name imuldw
* @memberof ns
* @readonly
* @type {Function}
* @see {@link module:@stdlib/math/base/ops/imuldw}
*/
setReadOnly( ns, 'imuldw', require( '@stdlib/math/base/ops/imuldw' ) );

/**
* @name umuldw
* @memberof ns
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/math/base/ops/umuldw/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ for ( i = 0xFFFFFFF0; i < 0xFFFFFFFF; i++ ) {

## See Also

- <span class="package-name">[`@stdlib/math/base/ops/imuldw`][@stdlib/math/base/ops/imuldw]</span><span class="delimiter">: </span><span class="description">compute the double word product of two signed 32-bit integers.</span>
- <span class="package-name">[`@stdlib/number/int32/base/muldw`][@stdlib/number/int32/base/muldw]</span><span class="delimiter">: </span><span class="description">compute the double word product of two signed 32-bit integers.</span>
- <span class="package-name">[`@stdlib/number/uint32/base/mul`][@stdlib/number/uint32/base/mul]</span><span class="delimiter">: </span><span class="description">perform C-like multiplication of two unsigned 32-bit integers.</span>

</section>
Expand All @@ -125,7 +125,7 @@ for ( i = 0xFFFFFFF0; i < 0xFFFFFFFF; i++ ) {

<!-- <related-links> -->

[@stdlib/math/base/ops/imuldw]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/ops/imuldw
[@stdlib/number/int32/base/muldw]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/number/int32/base/muldw

[@stdlib/number/uint32/base/mul]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/number/uint32/base/mul

Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/alias2pkg/data/data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ base.hypotf,"@stdlib/math/base/special/hypotf"
base.identity,"@stdlib/math/base/special/identity"
base.identityf,"@stdlib/math/base/special/identityf"
base.imul,"@stdlib/number/int32/base/mul"
base.imuldw,"@stdlib/math/base/ops/imuldw"
base.imuldw,"@stdlib/number/int32/base/muldw"
base.int2slice,"@stdlib/slice/base/int2slice"
base.int32ToUint32,"@stdlib/number/int32/base/to-uint32"
base.inv,"@stdlib/math/base/special/inv"
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/alias2pkg/data/data.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/namespace/lib/namespace/base/i.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,15 @@
'value': require( '@stdlib/number/int32/base/mul' ),
'type': 'Function',
'related': [
'@stdlib/math/base/ops/imuldw',
'@stdlib/number/int32/base/muldw',
'@stdlib/math/base/ops/uimul'
]
});

ns.push({
'alias': 'base.imuldw',

Check warning on line 61 in lib/node_modules/@stdlib/namespace/lib/namespace/base/i.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "imuldw"
'path': '@stdlib/math/base/ops/imuldw',
'value': require( '@stdlib/math/base/ops/imuldw' ),
'path': '@stdlib/number/int32/base/muldw',
'value': require( '@stdlib/number/int32/base/muldw' ),
'type': 'Function',
'related': [
'@stdlib/number/int32/base/mul',
Expand Down Expand Up @@ -111,7 +111,7 @@
});

ns.push({
'alias': 'base.invf',

Check warning on line 114 in lib/node_modules/@stdlib/namespace/lib/namespace/base/i.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "invf"
'path': '@stdlib/math/base/special/invf',
'value': require( '@stdlib/math/base/special/invf' ),
'type': 'Function',
Expand Down Expand Up @@ -223,7 +223,7 @@
});

ns.push({
'alias': 'base.isnanf',

Check warning on line 226 in lib/node_modules/@stdlib/namespace/lib/namespace/base/i.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "isnanf"
'path': '@stdlib/math/base/assert/is-nanf',
'value': require( '@stdlib/math/base/assert/is-nanf' ),
'type': 'Function',
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/lib/namespace/base/u.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
});

ns.push({
'alias': 'base.umul',

Check warning on line 38 in lib/node_modules/@stdlib/namespace/lib/namespace/base/u.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "umul"
'path': '@stdlib/number/uint32/base/mul',
'value': require( '@stdlib/number/uint32/base/mul' ),
'type': 'Function',
Expand All @@ -45,12 +45,12 @@
});

ns.push({
'alias': 'base.umuldw',

Check warning on line 48 in lib/node_modules/@stdlib/namespace/lib/namespace/base/u.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "umuldw"
'path': '@stdlib/math/base/ops/umuldw',
'value': require( '@stdlib/math/base/ops/umuldw' ),
'type': 'Function',
'related': [
'@stdlib/math/base/ops/imuldw',
'@stdlib/number/int32/base/muldw',
'@stdlib/number/uint32/base/mul'
]
});
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/pkg2alias/data/data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@
"@stdlib/math/base/special/identity",base.identity
"@stdlib/math/base/special/identityf",base.identityf
"@stdlib/number/int32/base/mul",base.imul
"@stdlib/math/base/ops/imuldw",base.imuldw
"@stdlib/number/int32/base/muldw",base.imuldw
"@stdlib/slice/base/int2slice",base.int2slice
"@stdlib/number/int32/base/to-uint32",base.int32ToUint32
"@stdlib/math/base/special/inv",base.inv
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/pkg2alias/data/data.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/namespace/pkg2related/data/data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,8 +804,8 @@
"@stdlib/math/base/special/hypotf","@stdlib/math/base/special/hypot"
"@stdlib/math/base/special/identity",""
"@stdlib/math/base/special/identityf","@stdlib/math/base/special/identityf"
"@stdlib/number/int32/base/mul","@stdlib/math/base/ops/imuldw"
"@stdlib/math/base/ops/imuldw","@stdlib/number/int32/base/mul"
"@stdlib/number/int32/base/mul","@stdlib/number/int32/base/muldw"
"@stdlib/number/int32/base/muldw","@stdlib/number/int32/base/mul"
"@stdlib/slice/base/int2slice","@stdlib/slice/base/seq2slice,@stdlib/slice/base/str2slice"
"@stdlib/number/int32/base/to-uint32","@stdlib/number/uint32/base/to-int32"
"@stdlib/math/base/special/inv","@stdlib/math/base/special/pow"
Expand Down Expand Up @@ -1481,7 +1481,7 @@
"@stdlib/math/base/special/truncsd","@stdlib/math/base/special/ceilsd,@stdlib/math/base/special/floorsd,@stdlib/math/base/special/roundsd,@stdlib/math/base/special/trunc"
"@stdlib/number/uint32/base/to-int32",""
"@stdlib/number/uint32/base/mul","@stdlib/number/int32/base/mul"
"@stdlib/math/base/ops/umuldw","@stdlib/math/base/ops/imuldw,@stdlib/number/uint32/base/mul"
"@stdlib/math/base/ops/umuldw","@stdlib/number/int32/base/muldw,@stdlib/number/uint32/base/mul"
"@stdlib/string/base/uncapitalize","@stdlib/string/base/capitalize"
"@stdlib/string/base/uppercase","@stdlib/string/base/lowercase"
"@stdlib/math/base/special/vercos","@stdlib/math/base/special/cos,@stdlib/math/base/special/versin"
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/pkg2related/data/data.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/pkg2standalone/data/data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@
"@stdlib/math/base/special/identity","@stdlib/math-base-special-identity"
"@stdlib/math/base/special/identityf","@stdlib/math-base-special-identityf"
"@stdlib/number/int32/base/mul","@stdlib/number-int32-base-mul"
"@stdlib/math/base/ops/imuldw","@stdlib/math-base-ops-imuldw"
"@stdlib/number/int32/base/muldw","@stdlib/math-base-ops-imuldw"
"@stdlib/slice/base/int2slice","@stdlib/slice-base-int2slice"
"@stdlib/number/int32/base/to-uint32","@stdlib/number-int32-base-to-uint32"
"@stdlib/math/base/special/inv","@stdlib/math-base-special-inv"
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/pkg2standalone/data/data.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/standalone2pkg/data/data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@
"@stdlib/math-base-special-identity","@stdlib/math/base/special/identity"
"@stdlib/math-base-special-identityf","@stdlib/math/base/special/identityf"
"@stdlib/number-int32-base-mul","@stdlib/number/int32/base/mul"
"@stdlib/math-base-ops-imuldw","@stdlib/math/base/ops/imuldw"
"@stdlib/math-base-ops-imuldw","@stdlib/number/int32/base/muldw"
"@stdlib/slice-base-int2slice","@stdlib/slice/base/int2slice"
"@stdlib/number-int32-base-to-uint32","@stdlib/number/int32/base/to-uint32"
"@stdlib/math-base-special-inv","@stdlib/math/base/special/inv"
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/namespace/standalone2pkg/data/data.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/number/int32/base/mul/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ for ( i = 0; i < 100; i++ ) {

## See Also

- <span class="package-name">[`@stdlib/math/base/ops/imuldw`][@stdlib/math/base/ops/imuldw]</span><span class="delimiter">: </span><span class="description">compute the double word product of two signed 32-bit integers.</span>
- <span class="package-name">[`@stdlib/number/int32/base/muldw`][@stdlib/number/int32/base/muldw]</span><span class="delimiter">: </span><span class="description">compute the double word product of two signed 32-bit integers.</span>

</section>

Expand All @@ -116,7 +116,7 @@ for ( i = 0; i < 100; i++ ) {

<!-- <related-links> -->

[@stdlib/math/base/ops/imuldw]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/ops/imuldw
[@stdlib/number/int32/base/muldw]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/number/int32/base/muldw

<!-- </related-links> -->

Expand Down
4 changes: 2 additions & 2 deletions ...es/@stdlib/math/base/ops/imuldw/README.md → ...@stdlib/number/int32/base/muldw/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ limitations under the License.
## Usage

```javascript
var imuldw = require( '@stdlib/math/base/ops/imuldw' );
var imuldw = require( '@stdlib/number/int32/base/muldw' );
```

#### imuldw( a, b )
Expand Down Expand Up @@ -84,7 +84,7 @@ var bool = ( v === out );

```javascript
var lpad = require( '@stdlib/string/left-pad' );
var imuldw = require( '@stdlib/math/base/ops/imuldw' );
var imuldw = require( '@stdlib/number/int32/base/muldw' );

var i;
var j;
Expand Down
0 ...th/base/ops/imuldw/benchmark/benchmark.js → ...r/int32/base/muldw/benchmark/benchmark.js
View file
Open in desktop
File renamed without changes.
0 ...stdlib/math/base/ops/imuldw/docs/repl.txt → ...lib/number/int32/base/muldw/docs/repl.txt
View file
Open in desktop
File renamed without changes.
0 ...ath/base/ops/imuldw/docs/types/index.d.ts → ...er/int32/base/muldw/docs/types/index.d.ts
View file
Open in desktop
File renamed without changes.
0 ...b/math/base/ops/imuldw/docs/types/test.ts → ...umber/int32/base/muldw/docs/types/test.ts
View file
Open in desktop
File renamed without changes.
0 ...ib/math/base/ops/imuldw/examples/index.js → ...number/int32/base/muldw/examples/index.js
View file
Open in desktop
File renamed without changes.
0 ...stdlib/math/base/ops/imuldw/lib/assign.js → ...lib/number/int32/base/muldw/lib/assign.js
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...@stdlib/math/base/ops/imuldw/lib/index.js → ...dlib/number/int32/base/muldw/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
/**
* Perform multiplication of two signed 32-bit integers and return an array of two signed 32-bit integers which represents the signed 64-bit integer product.
*
* @module @stdlib/math/base/ops/imuldw
* @module @stdlib/number/int32/base/muldw
*
* @example
* var imuldw = require( '@stdlib/math/base/ops/imuldw' );
* var imuldw = require( '@stdlib/number/int32/base/muldw' );
*
* var v = imuldw( 0xAAAAAAAA, 0x55555555 );
* // returns [ -477218589, 1908874354 ]
Expand Down
0 .../@stdlib/math/base/ops/imuldw/lib/main.js → ...tdlib/number/int32/base/muldw/lib/main.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...@stdlib/math/base/ops/imuldw/package.json → ...dlib/number/int32/base/muldw/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@stdlib/math/base/ops/imuldw",
"name": "@stdlib/number/int32/base/muldw",
"version": "0.0.0",
"description": "Compute the double word product of two signed 32-bit integers.",
"license": "Apache-2.0",
Expand Down
0 .../base/ops/imuldw/test/fixtures/c/Makefile → ...int32/base/muldw/test/fixtures/c/Makefile
View file
Open in desktop
File renamed without changes.
0 ...base/ops/imuldw/test/fixtures/c/data.json → ...nt32/base/muldw/test/fixtures/c/data.json
View file
Open in desktop
File renamed without changes.
0 .../base/ops/imuldw/test/fixtures/c/runner.c → ...int32/base/muldw/test/fixtures/c/runner.c
View file
Open in desktop
File renamed without changes.
0 .../math/base/ops/imuldw/test/test.assign.js → ...mber/int32/base/muldw/test/test.assign.js
View file
Open in desktop
File renamed without changes.
0 ...@stdlib/math/base/ops/imuldw/test/test.js → ...dlib/number/int32/base/muldw/test/test.js
View file
Open in desktop
File renamed without changes.
0 ...ib/math/base/ops/imuldw/test/test.main.js → ...number/int32/base/muldw/test/test.main.js
View file
Open in desktop
File renamed without changes.