-
-
Notifications
You must be signed in to change notification settings - Fork 903
feat: added accessor protocol support to stats/base/meanpn
#5908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d5a6924
fix: fixes given comments on the given commit
dhruvilmehta 4394680
feat: added accessor protocol for meanpn
dhruvilmehta bfbb184
fix: fixed coyright years
dhruvilmehta 1755ddf
fix: fixed coyright years
dhruvilmehta 3df21eb
Discard changes to lib/node_modules/@stdlib/stats/base/dnanvariancech…
kgryte fc56de0
Update lib/node_modules/@stdlib/stats/base/meanpn/README.md
dhruvilmehta 03610a2
Discard changes to lib/node_modules/@stdlib/stats/base/meanpn/benchma…
kgryte fd45646
Discard changes to lib/node_modules/@stdlib/stats/base/meanpn/test/te…
kgryte a26e913
fix: made suggested changes
dhruvilmehta a16b58c
fix: made suggested changes
dhruvilmehta cc210a5
docs: update copy
kgryte 45a7b68
docs: remove unused imports in example
kgryte c078d8d
docs: update copy
kgryte 945b3fa
Apply suggestions from code review
kgryte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
lib/node_modules/@stdlib/stats/base/meanpn/benchmark/benchmark.ndarray.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
lib/node_modules/@stdlib/stats/base/meanpn/lib/accessors.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2025 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var gsumpw = require( '@stdlib/blas/ext/base/gsumpw' ).ndarray; | ||
var gapxsumpw = require( '@stdlib/blas/ext/base/gapxsumpw' ).ndarray; | ||
|
||
|
||
// MAIN // | ||
|
||
/** | ||
* Computes the arithmetic mean of a strided array using a two-pass error correction algorithm. | ||
* | ||
* @param {PositiveInteger} N - number of indexed elements | ||
dhruvilmehta marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* @param {NumericArray} x - input array | ||
dhruvilmehta marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* @param {integer} strideX - stride length | ||
* @param {NonNegativeInteger} offsetX - starting index | ||
* @returns {number} arithmetic mean | ||
* | ||
* @example | ||
* var floor = require( '@stdlib/math/base/special/floor' ); | ||
* var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' ); | ||
* var arraylike2object = require( '@stdlib/array/base/arraylike2object' ); | ||
* | ||
* var x = toAccessorArray([ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ]); | ||
dhruvilmehta marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
* var N = floor( x.length / 2 ); | ||
* | ||
* var v = meanpn( N, arraylike2object(x), 2, 1 ); | ||
* // returns 1.25 | ||
*/ | ||
function meanpn( N, x, strideX, offsetX ) { | ||
var xbuf; | ||
var get; | ||
var ix; | ||
var mu; | ||
var c; | ||
|
||
xbuf = x.data; | ||
|
||
get = x.accessors[ 0 ]; | ||
|
||
if ( N === 1 || strideX === 0 ) { | ||
return get( xbuf, offsetX ); | ||
} | ||
|
||
kgryte marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
ix = offsetX; | ||
kgryte marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
// Compute an estimate for the meanpn: | ||
mu = gsumpw( N, xbuf, strideX, ix ) / N; | ||
|
||
// Compute an error term: | ||
c = gapxsumpw( N, -mu, xbuf, strideX, ix ) / N; | ||
return mu + c; | ||
kgryte marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
|
||
// EXPORTS // | ||
|
||
module.exports = meanpn; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.