Skip to content

Conversation

dhanyabad11
Copy link
Contributor

@dhanyabad11 dhanyabad11 commented Mar 10, 2025

This PR addresses the comments from commit eac21cf and fixes the following issues:

Fixed missing space between if and ( r == 1.0 ) in src/main.c.
Ensured proper formatting consistency in expressions.
These changes improve code readability and maintain coding style consistency. Let me know if any further modifications are needed. 🚀

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 10, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@dhanyabad11 dhanyabad11 changed the title Fix quantile implementation fix: Ensure proper spacing in src/main.c Mar 10, 2025
@dhanyabad11 dhanyabad11 changed the title fix: Ensure proper spacing in src/main.c fixed: Ensure proper spacing in src/main.c Mar 10, 2025
@dhanyabad11 dhanyabad11 changed the title fixed: Ensure proper spacing in src/main.c feat: Ensure proper spacing in src/main.c Mar 10, 2025
@dhanyabad11 dhanyabad11 changed the title feat: Ensure proper spacing in src/main.c chore: Ensure proper spacing in src/main.c Mar 10, 2025
@dhanyabad11 dhanyabad11 changed the title chore: Ensure proper spacing in src/main.c chore: fix proper spacing in src/main.c Mar 10, 2025
@kgryte kgryte added the autoclose: Project Conventions Pull request which should be auto-closed due to not following project conventions. label Apr 30, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as this pull request does not follow project conventions.

We place a high value on consistency throughout the stdlib codebase, and this pull request was found to significantly deviate from stdlib conventions. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.

  • If you are attempting to contribute a new package, sometimes the best approach is to simply copy the contents of an existing package and then modify the minimum amount necessary to implement the feature (e.g., changing descriptions, parameter names, and implementation).
  • If you are contributing tests, find a package implementing a similar feature and emulate the tests of that package.
  • If you are updating documentation, examine several similar packages and emulate the content, style, and prose of those packages.

In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before continuing to work on this pull request.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Apr 30, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Project Conventions Pull request which should be auto-closed due to not following project conventions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants