Skip to content

Fix frechet logcdf comments #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix frechet logcdf comments #5997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ba2e62
Fix JavaScript lint errors #5814
nishant1194 Mar 6, 2025
5b134cb
Merge pull request #1 from nishant1194/nishant1194-patch-1
nishant1194 Mar 6, 2025
90e5a90
Merge branch 'stdlib-js:develop' into develop
nishant1194 Mar 12, 2025
039bfb9
fix: move constant before doc comment and remove extra space in retur…
nishant1194 Mar 12, 2025
ad2e884
fix: correct indexing style and return value in frechet logcdf
nishant1194 Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/node_modules/@stdlib/assert/is-electron-main/lib/process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/

'use strict';
const process = require('process');

// MODULES //

Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ Evaluates the natural logarithm of the [cumulative distribution function][cdf] (

```c
double y = stdlib_base_frechet_logcdf( 10.0, 2.0, 3.0, 2.0 );
// returns ~0.141
// returns ~-0.141
```

The function accepts the following arguments:
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/benchmark/c/benchmark.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ static double benchmark( void ) {

t = tic();
for ( i = 0; i < ITERATIONS; i++ ) {
y = stdlib_base_dists_frechet_logcdf( x[i%100], alpha[ i%100 ], s[ i%100 ], m[ i%100 ] );
y = stdlib_base_dists_frechet_logcdf( x[ i%100 ], alpha[ i%100 ], s[ i%100 ], m[ i%100 ] );
if ( y != y ) {
printf( "should not return NaN\n" );
break;
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/stats/base/dists/frechet/logcdf/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
*
* @example
* double y = stdlib_base_dists_frechet_logcdf( 10.0, 2.0, 3.0, 2.0 );
* // returns ~0.141
* // returns ~-0.141
*/
double stdlib_base_dists_frechet_logcdf( const double x, const double alpha, const double s, const double m ) {
double z;
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include "stdlib/stats/base/dists/uniform/stdev.h"
#include "stdlib/math/base/assert/is_nan.h"

static const double SQRT_ONE_TWELFTH = 0.28867513459481287; // stdlib_base_sqrt( 1.0/12.0 )
/**
* Returns the standard deviation of a uniform distribution.
*
Expand All @@ -31,7 +32,6 @@
* // returns ~2.309
*/

static const double SQRT_ONE_TWELFTH = 0.28867513459481287; // stdlib_base_sqrt( 1.0/12.0 )

double stdlib_base_dists_uniform_stdev( const double a, const double b ) {
if (
Expand All @@ -41,5 +41,5 @@ double stdlib_base_dists_uniform_stdev( const double a, const double b ) {
) {
return 0.0 / 0.0; // NaN
}
return SQRT_ONE_TWELFTH * ( b-a );
return SQRT_ONE_TWELFTH * ( b-a );
}
Loading