Skip to content

Conversation

abhishekblue
Copy link
Contributor

@abhishekblue abhishekblue commented Mar 13, 2025

Resolves #5556

Description

What is the purpose of this pull request?

This pull request:

  • introduces the @stdlib/stats/incr/nanewmean package, which incrementally computes an exponentially weighted mean, ignoring NaN values.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Mar 13, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 13, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanewmean $\color{green}131/131$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}131/131$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@abhishekblue abhishekblue marked this pull request as ready for review March 13, 2025 09:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 13, 2025
Copy link
Contributor

@hrshya hrshya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to import isnan from @stdlib/math/base/assert/is-nan and replace isNaN with isnan in main.js and other files.

@abhishekblue
Copy link
Contributor Author

@hrshya Thank you for pointing out.

@abhishekblue abhishekblue changed the title feat: add stats/incr/nanewmean feat: add stats/incr/nanewmean Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanewmean

3 participants