Skip to content

Conversation

Shivam-1827
Copy link
Contributor

Resolves #6004

Description

What is the purpose of this pull request?

This pull request:

fixes JavaScript linting failures detected in the automated workflow run on 2025-03-13. Specifically, it addresses two issues.

  • A require-globals violation in lib/node_modules/@stdlib/utils/get-prototype-of/lib/polyfill.js where an Object is used without loading it via require()
  • A module resolution error in lib/node_modules/@stdlib/_tools/pkgs/deps/lib/sync.js where the code is trying to import '/foo/bar/baz' which cannot be found

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The JavaScript linting failures were detected in the automated workflow run on 2025-03-13 00:09:28 UTC:

  • In lib/node_modules/@stdlib/utils/get-prototype-of/lib/polyfill.js (line 45:22): Object is used without loading it beforehand via require() (stdlib/require-globals)
  • In lib/node_modules/@stdlib/_tools/pkgs/deps/lib/sync.js (line 43:1): Encountered an error while running code: Cannot find module '/foo/bar/baz'

Additionally, a C Linting workflow failure was detected in a separate run on 2025-03-13 00:13:23 UTC.
These issues can be fixed by:

  • Properly requiring the Object global in the polyfill.js file.
  • Fixing the module path in sync.js.
  • Addressing the C linting errors identified in the same workflow.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 14, 2025
@kgryte
Copy link
Member

kgryte commented Mar 17, 2025

Thank you for your contribution; however, the referenced issue was already addressed in #6029. As such, I'll go ahead and close...

@kgryte kgryte closed this Mar 17, 2025
@kgryte kgryte added Duplicate This issue or pull request already exists. and removed Needs Review A pull request which needs code review. labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Duplicate This issue or pull request already exists. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants