feat: add accessor protocol support and refactor `stats/base/nanvariancech` #6048

rahulptl165 · 2025-03-14T18:47:36Z

…riancech

Resolves #5674 .

Description

What is the purpose of this pull request?
Add accessor protocol support and refactored @stdlib/stats/base/nanvariancech.

This pull request:

{{TODO: add description describing what this pull request does}}
Add new file lib/accessors.js.
modify lib/ndaaray.js.
modify lib/nanvariancech.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: refactor and add protocol support to stats/base/nanvariancech #5674

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

…riancech

stdlib-bot · 2025-03-14T18:48:41Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/nanvariancech	$\color{green}396/396$ $\color{green}+100.00\%$	$\color{green}46/46$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}396/396$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

aayush0325 · 2025-03-16T11:43:40Z

lib/node_modules/@stdlib/stats/base/nanvariancech/lib/accessors.js

+	if ( N <= 0 ) {
+		return NaN;
+	}


Suggested change

if ( N <= 0 ) {

return NaN;

}

this is already being checked for in ndarray.js

aayush0325 · 2025-03-16T11:44:19Z

lib/node_modules/@stdlib/stats/base/nanvariancech/lib/accessors.js

+
+	// Find an estimate for the mean...
+	for ( i = 0; i < N; i++ ) {
+		v = xget( xbuf, ix);


Suggested change

v = xget( xbuf, ix);

v = xget( xbuf, ix );

aayush0325 · 2025-03-16T11:47:23Z

lib/node_modules/@stdlib/stats/base/nanvariancech/examples/index.js

https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/stats/base/dnanvariancepn/examples/index.js

kindly refer to this to see how we write examples. also, use generic data type instead of float64

aayush0325 · 2025-03-16T11:47:43Z

lib/node_modules/@stdlib/stats/base/nanvariancech/docs/types/test.ts

why are you deleting this file...

aayush0325 · 2025-03-16T11:49:18Z

lib/node_modules/@stdlib/stats/base/nanvariancech/README.md

 ```javascript
-var floor = require( '@stdlib/math/base/special/floor' );
-
 var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ];


Suggested change

var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ];

var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ];

we should explicitly show how we're handling the NaN element

aayush0325 · 2025-03-16T11:49:53Z

lib/node_modules/@stdlib/stats/base/nanvariancech/README.md

-var N = floor( x.length / 2 );

-var v = nanvariancech.ndarray( N, 1, x, 2, 1 );
+var v = nanvariancech.ndarray( 4, 1, x, 2, 1 );


Suggested change

var v = nanvariancech.ndarray( 4, 1, x, 2, 1 );

var v = nanvariancech.ndarray( 5, 1, x, 2, 1 );

aayush0325 · 2025-03-16T11:50:09Z

lib/node_modules/@stdlib/stats/base/nanvariancech/README.md

-var round = require( '@stdlib/math/base/special/round' );
-var Float64Array = require( '@stdlib/array/float64' );
+var normal = require( '@stdlib/random/array/normal' );
 var nanvariancech = require( '@stdlib/stats/base/nanvariancech' );

-var x;
-var i;
-
-x = new Float64Array( 10 );
-for ( i = 0; i < x.length; i++ ) {
-    x[ i ] = round( (randu()*100.0) - 50.0 );
-}
+var x = normal( 10, 0, 1 );
+x[4] = NaN;


same comments as examples/index.js

aayush0325 · 2025-03-16T11:50:52Z

lib/node_modules/@stdlib/stats/base/nanvariancech/benchmark/benchmark.js

https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/stats/base/dnanvariancepn/benchmark/benchmark.js

kindly use this as a reference

same comments for your other benchmark file

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

rahulptl165 · 2025-03-17T12:43:32Z

Hi @aayush0325, i have implemented the requested changes. Please let me know if you need any further modification.

aayush0325 · 2025-03-18T18:05:19Z

kindly address the CI failure errors before further review, this saves a lot of time for both of us! thank you :)

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

rahulptl165 · 2025-03-18T23:01:22Z

Hi @aayush0325, I’m sorry for any confusion caused. this branch was removed to address some concerns. A new PR #6167 is now available with the requested changes.

Sorry again !

Add accessor protocol support and refactored @stdlib/stats/base/nanva…

db90eb5

…riancech

aayush0325 requested changes Mar 16, 2025

View reviewed changes

aayush0325 changed the title ~~feat: Add accessor protocol support and refactored @stdlib/stats/base/nanvariancech~~ feat: add accessor protocol support and refactor stats/base/nanvariancech Mar 16, 2025

stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 18, 2025

rahulptl165 force-pushed the feat/accessor-nanvariancech branch from 5c97c25 to 06fc847 Compare March 18, 2025 21:23

rahulptl165 closed this Mar 18, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 18, 2025

rahulptl165 deleted the feat/accessor-nanvariancech branch March 18, 2025 21:30

	var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ];
	var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ];

	var v = nanvariancech.ndarray( 4, 1, x, 2, 1 );
	var v = nanvariancech.ndarray( 5, 1, x, 2, 1 );

Uh oh!

feat: add accessor protocol support and refactor stats/base/nanvariancech #6048

feat: add accessor protocol support and refactor stats/base/nanvariancech #6048

Uh oh!

Conversation

rahulptl165 commented Mar 14, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rahulptl165 commented Mar 17, 2025

Uh oh!

aayush0325 commented Mar 18, 2025

Uh oh!

rahulptl165 commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add accessor protocol support and refactor `stats/base/nanvariancech` #6048

feat: add accessor protocol support and refactor `stats/base/nanvariancech` #6048

stdlib-bot commented Mar 14, 2025 •

edited

Loading