Skip to content

Conversation

Krishna-Sharma-g
Copy link
Contributor

Resolves #6054

Description

What is the purpose of this pull request?

This pull request:

  • lint error

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 15, 2025
@Krishna-Sharma-g Krishna-Sharma-g changed the title some changes chore: resolve javascript lint error Mar 15, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 15, 2025

Coverage Report

Package Statements Branches Functions Lines
napi/argv-complex128 $\color{green}147/147$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}147/147$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@ishwarthecodddr
Copy link

how does this fix the linting error? could you explain just curious

@Krishna-Sharma-g
Copy link
Contributor Author

@ishwarthecodddr Looking at the C code in addon.c, there's a mismatch between the expected complex number values in the assertion and what it is passing in JavaScript native.js

@Krishna-Sharma-g
Copy link
Contributor Author

@aayush0325 please review

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 17, 2025
@kgryte kgryte merged commit 6281551 into stdlib-js:develop Mar 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

5 participants