Skip to content

Conversation

Girish-Garg
Copy link
Contributor

Resolves #5624.

Description

What is the purpose of this pull request?

This pull request:

  • add incremental corrected sample standard deviation function that ignores NaN values
  • added more tests to check NaN

test:
image

example:
image

benchmark:
image

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 16, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanstdev $\color{green}186/186$
$\color{green}+100.00\%$
$\color{red}26/27$
$\color{green}+96.30\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}186/186$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Girish-Garg
Copy link
Contributor Author

Hi @kgryte , this is my first PR. I’d appreciate your review to help me identify any errors or improvements. Your feedback will help me contribute more effectively to future issues.
Thanks

@kgryte kgryte added Duplicate This issue or pull request already exists. and removed Needs Review A pull request which needs code review. labels Mar 31, 2025
@kgryte
Copy link
Member

kgryte commented Mar 31, 2025

Ref: #5798

@kgryte kgryte added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label Mar 31, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Duplicate This issue or pull request already exists. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanstdev

3 participants