Skip to content

Conversation

Jeevansm25
Copy link

Added accessor protocol support with accessors.js, updated ndarray.js to delegate, and added tests per RFC.
Resolves #5686

Description

This pull request:

  • Adds accessor protocol support with a new accessors.js file.
  • Updates ndarray.js to delegate to accessors.js for accessor arrays.
  • Modifies tests in test.ndarray.js to include accessor array cases.
  • Updates index.js to reflect changes.

Related Issues

Checklist

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers
[contributing]: https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 18, 2025
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/sstdevyc $\color{red}445/457$
$\color{green}+97.37\%$
$\color{red}34/41$
$\color{green}+82.93\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{red}445/457$
$\color{green}+97.37\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Apr 19, 2025
@kgryte kgryte added autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels Jun 8, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/stdevyc

3 participants