Skip to content

Conversation

Eternity0207
Copy link
Contributor

Resolves a part of #5431.

Description

What is the purpose of this pull request?

This pull request:

• Fixes the linting failures that were detected in the automated lint workflow run

8fa3827#r152950715.
Line 174: @stdlib-bot This return value is incorrect. The example should be updated to use similar values as L61 and the return value should be updated accordingly.

8fa3827#r152950726
Line 218: @stdlib-bot Variables should be ordered based on length.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 19, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/cauchy/cdf $\color{green}287/287$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}287/287$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Contributor

@hrshya hrshya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this PR to be reviewed further all commit comments needs to be addressed in a single PR.

@Eternity0207
Copy link
Contributor Author

@hrshya May you guide me how to do it?

@Eternity0207 Eternity0207 deleted the patch-6 branch March 19, 2025 09:19
@hrshya
Copy link
Contributor

hrshya commented Mar 19, 2025

Address the other comments and then commit the changes in the branch that you used to create this PR.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 19, 2025
@hrshya
Copy link
Contributor

hrshya commented Mar 19, 2025

I wouldn't recommend doing it directly for multiple file changes. If memory is a concern, you can use the --depth flag to fetch only the latest commit history. To get started, you can refer to https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md and @anandkaranubc Git cheatsheet ( https://github.com/stdlib-js/stdlib/pull/5753/files?short_path=9b3ba87#diff-9b3ba87cd5993cade07d2fba575929f9e73a600741c853d6842aa2c7367f17cd ), which would help you a lot if you're a beginner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants