Skip to content

Conversation

JaySoni1
Copy link
Contributor

@JaySoni1 JaySoni1 commented Mar 19, 2025

Resolves #5861

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 19, 2025
@JaySoni1 JaySoni1 changed the title Address commit comments (commit bc90eba) #5861 chore: address commit comments from bc90eba (#5861) Mar 20, 2025
@JaySoni1
Copy link
Contributor Author

@kgryte , @Planeshifter please review

1 similar comment
@JaySoni1
Copy link
Contributor Author

@kgryte , @Planeshifter please review

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 22, 2025
@kgryte
Copy link
Member

kgryte commented Mar 22, 2025

Unfortunately, this PR contains many unwanted changes and cannot be merged as is. As such, I am going to go ahead and close.

@kgryte kgryte closed this Mar 22, 2025
@kgryte kgryte added the Invalid Invalid question, issue, or pull request. label Mar 22, 2025
@JaySoni1
Copy link
Contributor Author

Thanks for the clarification @kgryte . I’ll create a fresh PR addressing the comments, ensuring only the intended changes are included. I’ll also make sure the commit history is clean. Will request a review once it’s ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit bc90eba)

3 participants