Skip to content

chore: fix javascript lint errors #6214 #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from
Closed

chore: fix javascript lint errors #6214 #6221

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
4f28c68
chore: fix JavaScript lint errors #6214
bhavishy2801 Mar 20, 2025
2340149
chore: fix JavaScript lint errors #6214
bhavishy2801 Mar 20, 2025
701c8b6
Update polyfill.js
bhavishy2801 Mar 21, 2025
7e15762
Update polyfill.js
bhavishy2801 Mar 21, 2025
b2d2c7c
Updated polyfill.js
bhavishy2801 Mar 23, 2025
b163856
Updated polyfill.js
bhavishy2801 Mar 23, 2025
e7dccbd
Updated polyfill.js
bhavishy2801 Mar 23, 2025
ed0570c
Updated polyfill.js
bhavishy2801 Mar 23, 2025
df9cd46
Updated polyfill.js
bhavishy2801 Mar 23, 2025
cc54540
Updated polyfill.js
bhavishy2801 Mar 23, 2025
175b6c8
Updated polyfill.js
bhavishy2801 Mar 23, 2025
43e1bbc
Updated polyfill.js
bhavishy2801 Mar 23, 2025
4d5dfa3
Updated main.js
bhavishy2801 Mar 23, 2025
09f7346
Updated polyfill.js
bhavishy2801 Mar 23, 2025
6980d23
Updated polyfill.js
bhavishy2801 Mar 23, 2025
5b12782
Updated polyfill.js
bhavishy2801 Mar 23, 2025
3b71ac6
Updated polyfill.js
bhavishy2801 Mar 23, 2025
f1e2e47
Updated polyfill.js
bhavishy2801 Mar 23, 2025
135d208
Updated polyfill.js
bhavishy2801 Mar 23, 2025
d6d8015
Updated polyfill.js
bhavishy2801 Mar 23, 2025
5f189c0
Updated polyfill.js
bhavishy2801 Mar 23, 2025
51620f6
Updated polyfill.js
bhavishy2801 Mar 23, 2025
a092b94
Updated polyfill.js
bhavishy2801 Mar 23, 2025
7e5a0f6
Updated polyfill.js
bhavishy2801 Mar 23, 2025
b43e355
Updated polyfill.js
bhavishy2801 Mar 23, 2025
a7c39ab
Updated polyfill.js
bhavishy2801 Mar 23, 2025
da25f36
Updated polyfill.js
bhavishy2801 Mar 23, 2025
978501e
Updated polyfill.js
bhavishy2801 Mar 23, 2025
b8c4077
Updated polyfill.js
bhavishy2801 Mar 23, 2025
a90e1e3
Updated polyfill.js
bhavishy2801 Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/proxy/ctor/lib/main.js
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this file should be reverted, as they are not desired. The entire point of the doctest is to demonstrate how proxies allow for intercepting property access.

Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
*
* @example
* function get( obj, prop ) {
* return obj[ prop ] * 2.0;
* return obj[ prop ] * 1.0;
* }
*
* var handlers = {
Expand All @@ -44,7 +44,7 @@
* p.a = 3.14;
*
* var x = p.a;
* // returns 6.28
* // returns 3.14
*/
var proxy = ( typeof Proxy === 'undefined' ) ? null : Proxy; // eslint-disable-line stdlib/require-globals, node/no-unsupported-features/es-builtins

Expand Down
5 changes: 3 additions & 2 deletions lib/node_modules/@stdlib/proxy/ctor/lib/polyfill.js
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes are not the desired changes, in this case. Instead, because we still need the polyfill implementation, at L47, you should just disable doctesting using a eslint-disable-line comment. This rule can be re-enabled once the polyfill is completed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have also yet to revert the changes to this file.

Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*
* @example
* function get( obj, prop ) {
* return obj[ prop ] * 2.0;
* return obj[ prop ] * 1.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be reverted.

* }
*
* var handlers = {
Expand All @@ -42,9 +42,10 @@
* p.a = 3.14;
*
* var x = p.a;
* // returns 6.28
* // returns 3.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be reverted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte but now, it's failing the check in lint_changed_files,

`Run # Determine root directory:
make[1]: Entering directory '/home/runner/work/stdlib/stdlib'

Linting file: lib/node_modules/@stdlib/proxy/ctor/lib/polyfill.js

/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/proxy/ctor/lib/polyfill.js
Error: 23:1 error Displayed return value is 6.28, but expected 3.14 instead stdlib/jsdoc-doctest

✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the --fix option.

make[1]: *** [/home/runner/work/stdlib/stdlib/tools/make/lib/lint/javascript/eslint.mk:249: eslint-files] Error 1
make[1]: Leaving directory '/home/runner/work/stdlib/stdlib'
make: *** [/home/runner/work/stdlib/stdlib/tools/make/lib/lint/javascript/Makefile:158: lint-javascript-files] Error 2
Error: Process completed with exit code 2.`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, precisely, and that error message tells you exactly the lint rule you need to disable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte I've made some changes in the code of polyfill.js, but still it's showing the error:-

Error: 47:1 error Encountered an orphaned return annotation without a preceding node stdlib/jsdoc-doctest-marker

If I remove the * // eslint-disable-next-line stdlib/jsdoc-doctest-marker line, it will show error to use 3.14 instead of 6.28, and if I use the line, it shows the above error. Please guide

*/
function Proxy( target ) {
// eslint-disable-next-line no-warning-comments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still incorrect.

// TODO: polyfill implementation
return target;
}
Expand Down