Skip to content

Conversation

Girish-Garg
Copy link
Contributor

@Girish-Garg Girish-Garg commented Mar 20, 2025

Resolves #6222 .

Description

What is the purpose of this pull request?

This pull request:

  • add float32 eulergamma constant

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 20, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
constants/float32/eulergamma $\color{green}52/52$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}52/52$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Member

@Girish-Garg This is not what was expected I believe you have just copied the contants/float64/eulergamma to constants/float32 which is incorrect. If you would go through the issue description the changes were to be made in contants/float64/eulergamma specifically to change the var name from GAMMA to EULERGAMMA

@Girish-Garg
Copy link
Contributor Author

@Neerajpathak07 ohk i see what i did wrong there....i will close this PR then

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 20, 2025
@Neerajpathak07
Copy link
Member

@Girish-Garg No worries if you wanna work on more constants/float32 packages I'll do go ahead and look out which packages are present in constants/float64 but not in the single-precision one.
You can refer this for better clarity:- #6075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: update constants/float64/eulergamma to enforce consistency with EULERGAMMA

3 participants