Skip to content

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 20, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the math/base/special/max, math/base/special/maxf and math/base/special/maxn packages.
  • Replaces randu() with uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 20, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 20, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/max $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}16/16$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$
math/base/special/maxf $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}16/16$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$
math/base/special/maxn $\color{green}151/151$
$\color{green}+100.00\%$
$\color{green}25/25$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}151/151$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Harsh <[email protected]>
@kgryte kgryte added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label Mar 21, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte merged commit d20e133 into stdlib-js:develop Mar 21, 2025
11 checks passed
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 21, 2025
@hrshya hrshya deleted the fix/max branch April 10, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants