Skip to content

bench: update random value generation #6232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025
Merged

bench: update random value generation #6232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d97e712
bench: update random value generation
hrshya Mar 20, 2025
b99ebe4
bench: clean-up and resolve lint errors
kgryte Mar 21, 2025
cddcac7
bench: fix variable name
kgryte Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/math/base/special/negalucasf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ limitations under the License.
-->

# negaLucas
# negaLucasf

> Compute the nth [negaLucas number][lucas-number] in single-precision floating-point format.
Expand Down
133 changes: 67 additions & 66 deletions lib/node_modules/@stdlib/math/base/special/negalucasf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,13 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/array/discrete-uniform' );
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
var roundf = require( '@stdlib/math/base/special/roundf' );
var pow = require( '@stdlib/math/base/special/pow' );
var absf = require( '@stdlib/math/base/special/absf' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var PHI = require( '@stdlib/constants/float32/phi' );
var zeros = require( '@stdlib/array/base/zeros' );
var pkg = require( './../package.json' ).name;
var NEGALUCAS = require( './../lib/negalucas.json' );
var negalucasf = require( './../lib' );
Expand All @@ -39,7 +40,7 @@ bench( pkg, function benchmark( b ) {
var y;
var i;

x = randu( 100, -34, 0 );
x = discreteUniform( 100, -34, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand All @@ -61,12 +62,7 @@ bench( pkg+'::analytic', function benchmark( b ) {
var y;
var i;

x = randu( 100, -34, 0 );

function negalucasf( n ) {
var an = absf( n );
return pow( -1.0, an ) * roundf( pow( PHI, an ) );
}
x = discreteUniform( 100, -34, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand All @@ -81,14 +77,19 @@ bench( pkg+'::analytic', function benchmark( b ) {
}
b.pass( 'benchmark finished' );
b.end();

function negalucasf( n ) {
var an = absf( n );
return pow( -1.0, an ) * roundf( pow( PHI, an ) );
}
});

bench( pkg+'::table', function benchmark( b ) {
var x;
var y;
var i;

x = randu( 100, -34, 0 );
x = discreteUniform( 100, -34, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand All @@ -110,17 +111,7 @@ bench( pkg+'::naive_recursion', function benchmark( b ) {
var y;
var i;

function negalucasf( n ) {
if ( n === 0 ) {
return 2;
}
if ( n === -1 ) {
return -1;
}
return negalucasf( n+2 ) - negalucasf( n+1 );
}

x = randu( 100, -20, 0 );
x = discreteUniform( 100, -20, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand All @@ -135,6 +126,16 @@ bench( pkg+'::naive_recursion', function benchmark( b ) {
}
b.pass( 'benchmark finished' );
b.end();

function negalucasf( n ) {
if ( n === 0 ) {
return 2;
}
if ( n === -1 ) {
return -1;
}
return negalucasf( n+2 ) - negalucasf( n+1 );
}
});

bench( pkg+'::recursion_memoized', function benchmark( b ) {
Expand All @@ -144,11 +145,27 @@ bench( pkg+'::recursion_memoized', function benchmark( b ) {
var y;
var i;

arr = new Array( 35 );
arr = zeros( 35 );
arr[ 0 ] = 2;
arr[ 1 ] = -1;
N = 1;

x = discreteUniform( 100, -20, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = negalucasf( x[ i % x.length ] );
if ( isnanf( y ) ) {
b.fail( 'should not return NaN' );
}
}
b.toc();
if ( isnanf( y ) ) {
b.fail( 'should not return NaN' );
}
b.pass( 'benchmark finished' );
b.end();

function negalucasf( n ) {
var an = absf( n );
if ( an <= N ) {
Expand All @@ -157,8 +174,14 @@ bench( pkg+'::recursion_memoized', function benchmark( b ) {
arr[ an ] = negalucasf( n+2 ) - negalucasf( n+1 );
return arr[ an ];
}
});

x = randu( 100, -20, 0 );
bench( pkg+'::naive_iterative', function benchmark( b ) {
var x;
var y;
var i;

x = discreteUniform( 100, -34, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand All @@ -173,12 +196,6 @@ bench( pkg+'::recursion_memoized', function benchmark( b ) {
}
b.pass( 'benchmark finished' );
b.end();
});

bench( pkg+'::naive_iterative', function benchmark( b ) {
var x;
var y;
var i;

function negalucasf( n ) {
var arr;
Expand All @@ -187,16 +204,22 @@ bench( pkg+'::naive_iterative', function benchmark( b ) {

an = absf( n );

arr = new Array( an+1 );
arr = zeros( an+1 );
arr[ 0 ] = 2;
arr[ 1 ] = -1;
for ( i = 2; i <= an; i++ ) {
arr[ i ] = arr[ i-2 ] - arr[ i-1 ];
}
return arr[ an ];
}
});

bench( pkg+'::iterative', function benchmark( b ) {
var x;
var y;
var i;

x = randu( 100, -34, 0 );
x = discreteUniform( 100, -34, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand All @@ -211,12 +234,6 @@ bench( pkg+'::naive_iterative', function benchmark( b ) {
}
b.pass( 'benchmark finished' );
b.end();
});

bench( pkg+'::iterative', function benchmark( b ) {
var x;
var y;
var i;

function negalucasf( n ) {
var an;
Expand All @@ -236,8 +253,21 @@ bench( pkg+'::iterative', function benchmark( b ) {
}
return b;
}
});

bench( pkg+'::iterative_memoized', function benchmark( b ) {
var arr;
var N;
var x;
var y;
var i;

arr = zeros( 35 );
arr[ 0 ] = 2;
arr[ 1 ] = -1;
N = 2;

x = randu( 100, -34, 0 );
x = discreteUniform( 100, -34, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand All @@ -252,19 +282,6 @@ bench( pkg+'::iterative', function benchmark( b ) {
}
b.pass( 'benchmark finished' );
b.end();
});

bench( pkg+'::iterative_memoized', function benchmark( b ) {
var arr;
var N;
var x;
var y;
var i;

arr = new Array( 35 );
arr[ 0 ] = 2;
arr[ 1 ] = -1;
N = 2;

function negalucasf( n ) {
var an;
Expand All @@ -279,20 +296,4 @@ bench( pkg+'::iterative_memoized', function benchmark( b ) {
}
return arr[ an ];
}

x = randu( 100, -34, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = negalucasf( x[ i % x.length ] );
if ( isnanf( y ) ) {
b.fail( 'should not return NaN' );
}
}
b.toc();
if ( isnanf( y ) ) {
b.fail( 'should not return NaN' );
}
b.pass( 'benchmark finished' );
b.end();
});
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/math/base/special/negalucasf/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/array/discrete-uniform' );
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var tryRequire = require( '@stdlib/utils/try-require' );
var pkg = require( './../package.json' ).name;
Expand All @@ -43,7 +43,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
var y;
var i;

x = randu( 100, -34, 0 );
x = discreteUniform( 100, -34, 0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand Down
12 changes: 6 additions & 6 deletions lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,51 +46,51 @@
var v;
var i;

t.strictEqual( isnanf( negalucasf( 3.14 ) ), true, 'returns NaN' );
t.strictEqual( isnanf( negalucasf( 3.14 ) ), true, 'returns expected value' );

for ( i = 1; i < 100; i++ ) {
v = negalucasf( i );
t.strictEqual( isnanf( v ), true, 'returns NaN when provided ' + i );
t.strictEqual( isnanf( v ), true, 'returns expected value when provided ' + i );
}
t.end();
});

tape( 'if provided negative infinity, the function returns `NaN`', function test( t ) {
var v = negalucasf( NINF );
t.strictEqual( isnanf( v ), true, 'returns NaN when provided -infinity' );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.end();
});

tape( 'if provided `NaN`, the function returns `NaN`', function test( t ) {
var v = negalucasf( NaN );
t.strictEqual( isnanf( v ), true, 'returns NaN when provided a NaN' );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.end();
});

tape( 'if provided a non-integer, the function returns `NaN`', function test( t ) {
var v = negalucasf( -3.14 );
t.strictEqual( isnanf( v ), true, 'returns NaN' );
t.strictEqual( isnanf( v ), true, 'returns expected value' );
t.end();
});

tape( 'the function returns the nth negaLucas number', function test( t ) {

Check warning on line 76 in lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "nega"
var v;
var i;
for ( i = 0; i > -35; i-- ) {
v = negalucasf( i );
t.strictEqual( v, NEGALUCAS[ absf(i) ], 'returns the '+i+'th negaLucas number' );

Check warning on line 81 in lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "nega"
}
t.end();
});

tape( 'the function returns the nth negaLucas number (Lucas relationship)', function test( t ) {

Check warning on line 86 in lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "nega"
var v;
var f;
var i;
for ( i = 0; i > -35; i-- ) {
v = negalucasf( i );
f = pow( -1.0, absf(i) ) * lucas( absf(i) );
t.strictEqual( v, f, 'returns the '+i+'th negaLucas number' );

Check warning on line 93 in lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "nega"
}
t.end();
});
Expand All @@ -100,7 +100,7 @@
var v;
for ( i = -35; i > -500; i-- ) {
v = negalucasf( i );
t.strictEqual( isnanf( v ), true, 'returns NaN when provided ' + i );
t.strictEqual( isnanf( v ), true, 'returns expected value when provided ' + i );
}
t.end();
});
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,29 +56,29 @@

for ( i = 1; i < 100; i++ ) {
v = negalucasf( i );
t.strictEqual( isnanf( v ), true, 'returns NaN when provided ' + i );
t.strictEqual( isnanf( v ), true, 'returns expected value when provided ' + i );
}
t.end();
});

tape( 'the function returns the nth negaLucas number', opts, function test( t ) {

Check warning on line 64 in lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.native.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "nega"
var v;
var i;
for ( i = 0; i > -35; i-- ) {
v = negalucasf( i );
t.strictEqual( v, NEGALUCAS[ absf( i ) ], 'returns the '+i+'th negaLucas number' );

Check warning on line 69 in lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.native.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "nega"
}
t.end();
});

tape( 'the function returns the nth negaLucas number (Lucas relationship)', opts, function test( t ) {

Check warning on line 74 in lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.native.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "nega"
var v;
var f;
var i;
for ( i = 0; i > -35; i-- ) {
v = negalucasf( i );
f = pow( -1.0, absf(i) ) * lucas( absf(i) );
t.strictEqual( v, f, 'returns the '+i+'th negaLucas number' );

Check warning on line 81 in lib/node_modules/@stdlib/math/base/special/negalucasf/test/test.native.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "nega"
}
t.end();
});
Expand All @@ -88,7 +88,7 @@
var v;
for ( i = -35; i > -500; i-- ) {
v = negalucasf( i );
t.strictEqual( isnanf( v ), true, 'returns NaN when provided ' + i );
t.strictEqual( isnanf( v ), true, 'returns expected value when provided ' + i );
}
t.end();
});