Skip to content

Conversation

Eternity0207
Copy link
Contributor

Resolves #5898.

Description

What is the purpose of this pull request?

This pull request:

• Fixes the following issue

73d8eb8#r153449434
Line 114: @stdlib-bot This is not what is desired based on L115. Instead, L105-6 should be renamed (e.g., are and aim for arrays of reals and imaginaries, respectively). Then the output variables here should be re and im as in the original benchmark.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 20, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/ccis $\color{green}246/246$
$\color{green}+100.00\%$
$\color{green}6/6$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}246/246$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 20, 2025
@kgryte
Copy link
Member

kgryte commented Mar 21, 2025

Thank you for submitting this PR; however, the issue that this PR seeks to address has already been closed via #5943. As such, I'll go ahead and close.

@kgryte kgryte closed this Mar 21, 2025
@kgryte kgryte added Duplicate This issue or pull request already exists. and removed Needs Review A pull request which needs code review. labels Mar 21, 2025
@Eternity0207 Eternity0207 deleted the patch-8 branch October 6, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Duplicate This issue or pull request already exists. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 73d8eb8)

3 participants