Skip to content

chore: fix JavaScript lint errors #6247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+6 −4
Closed

chore: fix JavaScript lint errors #6247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b3566
Fix lint errors in mskmax.js
Eternity0207 Mar 21, 2025
02c657c
Fix issues in mskmax.js
Eternity0207 Mar 21, 2025
0e29563
fix JS lint errors
Eternity0207 Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etc/eslint/rules/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@
* // Good...
* console.log( 1, 2 );
*/
rules[ 'function-call-argument-newline' ] = [ 'error', 'never' ];
rules[ 'function-call-argument-newline' ] = [ 'error', 'consistent' ];

/**
* Never allow linebreaks inside parentheses of function parameters or arguments.
Expand Down Expand Up @@ -876,7 +876,7 @@
* @default [ 'off', 'starred-block' ]
* @see [multiline-comment-style]{@link https://eslint.org/docs/rules/multiline-comment-style}
*/
rules[ 'multiline-comment-style' ] = [ 'off', 'starred-block' ]; // TODO: enable once non-"aligned" blocks are supported

Check warning on line 879 in etc/eslint/rules/style.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: enable once non-"aligned" blocks...'

/**
* Allow same line or multiline ternary expressions.
Expand Down Expand Up @@ -1947,7 +1947,7 @@
*/
rules[ 'space-unary-ops' ] = [ 'error', {
'words': true,
'nonwords': false

Check warning on line 1950 in etc/eslint/rules/style.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

File has too many lines (315). Maximum allowed is 300
}];

/**
Expand Down
8 changes: 5 additions & 3 deletions lib/node_modules/@stdlib/stats/base/mskmax/lib/mskmax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,13 @@
* var v = mskmax( x.length, x, 1, mask, 1 );
* // returns 2.0
*/
function mskmax( N, x, strideX, mask, strideMask ) {
return ndarray( N, x, strideX, stride2offset( N, strideX ), mask, strideMask, stride2offset( N, strideMask ) );
function mskmax(N, x, strideX, mask, strideMask) {
return ndarray(

Check failure on line 47 in lib/node_modules/@stdlib/stats/base/mskmax/lib/mskmax.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected newline after '('
N, x, strideX, stride2offset(N, strideX),

Check failure on line 48 in lib/node_modules/@stdlib/stats/base/mskmax/lib/mskmax.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

There should be no line break here

Check failure on line 48 in lib/node_modules/@stdlib/stats/base/mskmax/lib/mskmax.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Trailing spaces not allowed
mask, strideMask, stride2offset(N, strideMask)
);

Check failure on line 50 in lib/node_modules/@stdlib/stats/base/mskmax/lib/mskmax.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected newline before ')'
}


// EXPORTS //

Check failure on line 53 in lib/node_modules/@stdlib/stats/base/mskmax/lib/mskmax.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Header comment must be preceded by one additional empty line

module.exports = mskmax;
Loading