Skip to content

Conversation

anandkaranubc
Copy link
Contributor

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • adds STDLIB_MATH_BASE_NAPI_MODULE_D_F macro in math/base/napi/unary

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 21, 2025
@anandkaranubc
Copy link
Contributor Author

Needed for sine and cosine kernels...

Reference

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 21, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/napi/unary $\color{green}153/153$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}153/153$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Mar 21, 2025
@anandkaranubc
Copy link
Contributor Author

anandkaranubc commented Mar 21, 2025

@kgryte

* @example
* static double scale( const double x ) {
* return x * 10.0;
* }

or

* static float scale( const float x ) {
* return x * 10.0f;
* }

Do these need to be changed accordingly too?

Or not because they are float->float and double->double...

@kgryte
Copy link
Member

kgryte commented Mar 21, 2025

Or not because they are float->float and double->double...

Correct. Those functions make sense.

@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 21, 2025
@kgryte kgryte merged commit 5a2afad into stdlib-js:develop Mar 21, 2025
60 checks passed
@anandkaranubc anandkaranubc deleted the napi/d-f branch March 21, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants