Skip to content

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 22, 2025

Progresses #649 .

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/num-significand-bits .

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 22, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float32/num-significand-bits $\color{green}47/47$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}47/47$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 22, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 22, 2025
@hrshya hrshya requested a review from kgryte March 23, 2025 12:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 23, 2025
@hrshya hrshya changed the title feat: add constants/float32/significand-bits feat: add constants/float32/num-significand-bits Mar 23, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 24, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 24, 2025
@kgryte kgryte merged commit 56b84a4 into stdlib-js:develop Mar 24, 2025
35 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
@hrshya hrshya deleted the feat/significand branch April 10, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants