Skip to content

feat: refactor and add protocol support to stats/base/nanrange-by #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Jul 5, 2025
Merged

feat: refactor and add protocol support to stats/base/nanrange-by #6440

merged 38 commits into from
Jul 5, 2025

Conversation

Kaushikgtm
Copy link
Contributor

@Kaushikgtm Kaushikgtm commented Mar 29, 2025 •
edited
Loading

Resolves #5666.

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: }

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Kaushikgtm added 13 commits March 29, 2025 15:21
@Kaushikgtm
Create accessors.js
7c0f342 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update accessors.js
14f0a5f 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update nanrange_by.js
7b487b1 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update ndarray.js
af57abf 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update test.nanrange_by.js
8f40fa3 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update test.ndarray.js
858f1ea 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update README.md
d5f8c58 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update index.js
d0d1f6a 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update index.d.ts
70b06be 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update test.ts
57ab24a 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update repl.txt
a29bea7 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update benchmark.js
752c833 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update benchmark.ndarray.js
d2f1311 
Signed-off-by: Kaushikgtm <[email protected]>
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Mar 29, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 29, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/nanrange-by $\color{green}334/334$
$\color{green}+100.00\%$ 		$\color{green}52/52$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}334/334$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Kaushikgtm
Update README.md
eb4442d 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update README.md
ff18103 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update README.md
530df0a 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm Kaushikgtm changed the title feat:refactor and add protocol support to stats/base/nanrange-by feat: refactor and add protocol support to stats/base/nanrange-by Mar 30, 2025
@Kaushikgtm
Update README.md
cdcf3f2 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update README.md
0bac446 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update accessors.js
b7b52a2 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update ndarray.js
8920c66 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update accessors.js
9008678 
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm
Update README.md
55a4cf2 
Signed-off-by: Kaushikgtm <[email protected]>
ShabiShett07
ShabiShett07 reviewed May 2, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/nanrange-by/README.md Outdated
<!-- eslint no-undef: "error" -->

```javascript
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unused package so no need of defining it.

@kgryte kgryte requested a review from gururaj1512 June 8, 2025 08:55
@kgryte kgryte changed the title feat: refactor and add protocol support to stats/base/nanrange-by feat: refactor and add protocol support to stats/base/nanrange-by Jun 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 8, 2025
@gururaj1512
Copy link
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 5, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 5, 2025
@gururaj1512
fix: readme file
1c53e34 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: benchmarks
92e7a5d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: update repl
945f05f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: update type definitions for nanrangeBy
08534e6 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: correct test.ts
ba4b452 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: examples
648f0e0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: implementation
bfaefbd
@gururaj1512
chore: minor cleanup
2c55276
@gururaj1512
fix: test files
4b34ad3 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
gururaj1512
gururaj1512 previously approved these changes Jul 5, 2025
View reviewed changes
@gururaj1512 gururaj1512 requested a review from kgryte July 5, 2025 10:02
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 5, 2025
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
@kgryte
test: update desc
fb50029 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
@kgryte
test: update desc
25fbf2d 
Signed-off-by: Athan <[email protected]>
@kgryte kgryte merged commit 4f78b17 into stdlib-js:develop Jul 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShabiShett07 ShabiShett07 ShabiShett07 left review comments

@kgryte kgryte kgryte approved these changes

@gururaj1512 gururaj1512 gururaj1512 left review comments

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/nanrange-by

5 participants

@Kaushikgtm @stdlib-bot @kgryte @gururaj1512 @ShabiShett07