feat: add C implementation for `blas/base/dsyr2` #6572

ShabiShett07 · 2025-04-05T19:28:52Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: na
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: missing_dependencies
task: lint_c_examples status: missing_dependencies
task: lint_c_benchmarks status: missing_dependencies
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: na
task: lint_typescript_tests status: na
task: lint_license_headers status: passed ---

Progresses #2039

Description

What is the purpose of this pull request?

This pull request:

adds package blas/base/dsyr2

Related Issues

Does this pull request have any related issues?

This pull request:

progresses [RFC]: Add BLAS bindings and implementations for linear algebra (tracking issue) #2039

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

ShabiShett07 · 2025-04-05T19:36:01Z

/stdlib update-copyright-years

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-04-06T06:54:48Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/base/dsyr2	$\color{green}667/667$ $\color{green}+100.00\%$	$\color{green}92/92$ $\color{green}+100.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{green}667/667$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Shabareesh Shetty <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Shabareesh Shetty <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Shabareesh Shetty <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Shabareesh Shetty <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

ShabiShett07 · 2025-07-12T13:23:52Z

/stdlib merge

Signed-off-by: Aman Bhansali <[email protected]>

aman-095

Make changes based on the comments.

lib/node_modules/@stdlib/blas/base/dsyr2/README.md

Signed-off-by: Shabareesh Shetty <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

ShabiShett07 · 2025-07-16T02:50:46Z

@aman-095, I have made some review and also left some comments

…/benchmark.ndarray.js

…/benchmark.js

lib/node_modules/@stdlib/blas/base/dsyr2/benchmark/benchmark.native.js

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/blas/base/dsyr2/benchmark/benchmark.ndarray.native.js

Signed-off-by: Athan <[email protected]>

lib/node_modules/@stdlib/blas/base/dsyr2/src/dsyr2_ndarray.c

Signed-off-by: Athan <[email protected]>

aman-095

Suggested some changes.

lib/node_modules/@stdlib/blas/base/dsyr2/benchmark/benchmark.js

lib/node_modules/@stdlib/blas/base/dsyr2/benchmark/c/benchmark.c

lib/node_modules/@stdlib/blas/base/dsyr2/examples/c/example.c

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte · 2025-07-16T05:38:32Z

@ShabiShett07 See this commit 47d2714 for the various changes which needed to be made.

kgryte

LGTM. Thanks, @aman-095, for reviewing.

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Apr 5, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 5, 2025

chore: update copyright years

441ce2e

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 5, 2025

ShabiShett07 marked this pull request as draft April 5, 2025 19:55

stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 5, 2025

fix: jsdoc examples

5bdfcf1

Signed-off-by: Shabareesh Shetty <[email protected]>

ShabiShett07 marked this pull request as ready for review April 6, 2025 08:30

stdlib-bot added the Needs Review A pull request which needs code review. label Apr 6, 2025

ShabiShett07 and others added 4 commits May 7, 2025 18:16

remove header files

f6fa175

Signed-off-by: Shabareesh Shetty <[email protected]>

ShabiShett07 marked this pull request as draft June 27, 2025 04:53

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 27, 2025

ShabiShett07 and others added 7 commits June 28, 2025 17:26

chore: minor clean-up

7eec8e6

Signed-off-by: Shabareesh Shetty <[email protected]>

chore: minor clean-up

b3e0f9f

Signed-off-by: Shabareesh Shetty <[email protected]>

chore: minor clean-up

57bf0f7

Signed-off-by: Shabareesh Shetty <[email protected]>

ShabiShett07 marked this pull request as ready for review June 28, 2025 13:14

stdlib-bot added the Needs Review A pull request which needs code review. label Jun 28, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 12, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 12, 2025

Merge remote-tracking branch 'upstream/develop' into feature/dsyr2

77b1dee

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 12, 2025

ShabiShett07 marked this pull request as ready for review July 12, 2025 18:02

stdlib-bot added the Needs Review A pull request which needs code review. label Jul 12, 2025

aman-095 added 2 commits July 15, 2025 11:49

Update README.md

3da5d9e

Signed-off-by: Aman Bhansali <[email protected]>

Update README.md

6e9d58b

Signed-off-by: Aman Bhansali <[email protected]>

aman-095 reviewed Jul 15, 2025

View reviewed changes

ShabiShett07 and others added 2 commits July 16, 2025 08:08

chore: update parameter descriptions

19ea8e0

Signed-off-by: Shabareesh Shetty <[email protected]>

ShabiShett07 requested a review from aman-095 July 16, 2025 02:50

kgryte added the C Issue involves or relates to C. label Jul 16, 2025

kgryte added 2 commits July 15, 2025 21:58

Discard changes to lib/node_modules/@stdlib/blas/base/dsyr2/benchmark…

f2dcd77

…/benchmark.ndarray.js

Discard changes to lib/node_modules/@stdlib/blas/base/dsyr2/benchmark…

c1666bf

…/benchmark.js

kgryte reviewed Jul 16, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/base/dsyr2/benchmark/benchmark.native.js Outdated Show resolved Hide resolved

docs: update description

cf37158

Signed-off-by: Athan <[email protected]>

kgryte reviewed Jul 16, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/base/dsyr2/benchmark/benchmark.ndarray.native.js Outdated Show resolved Hide resolved

docs: update description

76dd1a9

Signed-off-by: Athan <[email protected]>

kgryte reviewed Jul 16, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/base/dsyr2/src/dsyr2_ndarray.c Outdated Show resolved Hide resolved

fix: update error messages

704d508

Signed-off-by: Athan <[email protected]>

kgryte self-requested a review July 16, 2025 05:04

aman-095 reviewed Jul 16, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Jul 16, 2025

kgryte approved these changes Jul 16, 2025

View reviewed changes

kgryte merged commit 75e2622 into stdlib-js:develop Jul 16, 2025
12 checks passed

Uh oh!

feat: add C implementation for blas/base/dsyr2 #6572

feat: add C implementation for blas/base/dsyr2 #6572

Uh oh!

Conversation

ShabiShett07 commented Apr 5, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

ShabiShett07 commented Apr 5, 2025

Uh oh!

stdlib-bot commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

ShabiShett07 commented Jul 12, 2025

Uh oh!

aman-095 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShabiShett07 commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aman-095 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte commented Jul 16, 2025

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add C implementation for `blas/base/dsyr2` #6572

feat: add C implementation for `blas/base/dsyr2` #6572

stdlib-bot commented Apr 6, 2025 •

edited

Loading