Skip to content

fix: change strides parameter to be pointer to const #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025
Merged

fix: change strides parameter to be pointer to const #6610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2470e8e
fix: change strides parameter to be pointer to const
PraveshKunwar Apr 8, 2025
e771684
fix: changed ndims to be const
PraveshKunwar Apr 9, 2025
54a3756
style: add missing space
kgryte Apr 10, 2025
df2312a
Merge branch 'stdlib-js:develop' into praveshk/c-errors
PraveshKunwar Apr 10, 2025
1b6e869
fix: changed associated header file
PraveshKunwar Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../ndarray/base/assert/is-column-major/include/stdlib/ndarray/base/assert/is_column_major.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ extern "C" {
/**
* Determines if an array is column-major based on a provided stride array.
*/
int8_t stdlib_ndarray_is_column_major( int64_t ndims, int64_t *strides );
int8_t stdlib_ndarray_is_column_major( const int64_t ndims, const int64_t *strides );

#ifdef __cplusplus
}
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/ndarray/base/assert/is-column-major/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
* int8_t b = stdlib_ndarray_is_column_major( ndims, strides );
* // returns 1
*/
int8_t stdlib_ndarray_is_column_major( int64_t ndims, int64_t *strides ) {
int8_t stdlib_ndarray_is_column_major( const int64_t ndims, const int64_t *strides ) {
int64_t s1;
int64_t s2;
int64_t i;
Expand Down