Skip to content

Conversation

dipexplorer
Copy link
Contributor

@dipexplorer dipexplorer commented Apr 12, 2025

Resolves #6629

Description

What is the purpose of this pull request?

This pull request:

  • This PR fixes a C lint error in benchmark.length.c due to the use of VLAs.
    Replaced stack allocation with malloc and free to ensure compatibility with linters and large arrays.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 12, 2025
@kgryte
Copy link
Member

kgryte commented Apr 13, 2025

@dipexplorer None of the proposed changes actually addresses the lint error in #6629. You should see how we handle this lint error elsewhere in the codebase by doing a simple grep for the lint rule in question.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 13, 2025
@dipexplorer dipexplorer closed this by deleting the head repository Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

3 participants