Skip to content

fix: add missing values in error messages in blas/base/sgemv #6722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2025
Merged

fix: add missing values in error messages in blas/base/sgemv #6722

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61ecb0e
test: add test cases for blas/base/sgemv
ShabiShett07 Apr 19, 2025
db2ce99
fix: update test cases
ShabiShett07 Apr 19, 2025
4277a66
Apply suggestions from code review
kgryte Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/node_modules/@stdlib/blas/base/sgemv/lib/ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,17 @@ function sgemv( trans, M, N, alpha, A, strideA1, strideA2, offsetA, x, strideX,
if ( N < 0 ) {
throw new RangeError( format( 'invalid argument. Fourth argument must be a nonnegative integer. Value: `%d`.', N ) );
}
if ( strideA1 === 0 ) {
throw new RangeError( format( 'invalid argument. Sixth argument must be non-zero.', strideA1 ) );
}
if ( strideA2 === 0 ) {
throw new RangeError( format( 'invalid argument. Seventh argument must be non-zero.', strideA2 ) );
}
if ( strideX === 0 ) {
throw new RangeError( format( 'invalid argument. Eleventh argument must be non-zero.' ) );
throw new RangeError( format( 'invalid argument. Tenth argument must be non-zero.', strideX ) );
}
if ( strideY === 0 ) {
throw new RangeError( format( 'invalid argument. Fifteenth argument must be non-zero.' ) );
throw new RangeError( format( 'invalid argument. Fourteenth argument must be non-zero.', strideY ) );
}
// Check if we can early return...
if ( M === 0 || N === 0 || ( alpha === 0.0 && beta === 1.0 ) ) {
Expand Down
46 changes: 46 additions & 0 deletions lib/node_modules/@stdlib/blas/base/sgemv/test/test.ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,52 @@ tape( 'the function throws an error if provided an invalid third argument', func
}
});

tape( 'the function throws an error if provided an invalid sixth argument', function test( t ) {
var values;
var data;
var i;

data = rnt;

values = [
0
];

for ( i = 0; i < values.length; i++ ) {
t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
}
t.end();

function badValue( value ) {
return function badValue() {
sgemv( data.trans, data.M, data.N, data.alpha, new Float32Array( data.A ), value, data.strideA2, data.offsetA, new Float32Array( data.x ), data.strideX, data.offsetX, data.beta, new Float32Array( data.y ), data.strideY, data.offsetY );
};
}
});

tape( 'the function throws an error if provided an invalid seventh argument', function test( t ) {
var values;
var data;
var i;

data = rnt;

values = [
0
];

for ( i = 0; i < values.length; i++ ) {
t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
}
t.end();

function badValue( value ) {
return function badValue() {
sgemv( data.trans, data.M, data.N, data.alpha, new Float32Array( data.A ), data.strideA1, value, data.offsetA, new Float32Array( data.x ), data.strideX, data.offsetX, data.beta, new Float32Array( data.y ), data.strideY, data.offsetY );
};
}
});

tape( 'the function throws an error if provided an invalid tenth argument', function test( t ) {
var values;
var data;
Expand Down