-
-
Notifications
You must be signed in to change notification settings - Fork 996
feat: add C ndarray interface and refactor implementation for stats/base/dsempn
#6785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
/stdlib help |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@gururaj1512, available slash commands include:
|
|
/stdlib update-copyright-years |
Signed-off-by: Gururaj Gurram <[email protected]>
stats/base/dsempnstats/base/dsempn
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gururaj1512, for working on this. It will be nice to finally wrap up the stats/base work.
Sorry, I didn't get it...! |
|
@gururaj1512 I meant to say "thank you for continuing to work on these refactorings, as it will be nice to finally get all of these refactorings over the finish line!". We've still got a few more of these refactorings to complete and which will allow us to finally migrate to the |
|
Got it...! 😅 |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves None
Description
This pull request:
stats/base/dsempnRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers