Skip to content

Conversation

LalitNarayanYadav
Copy link
Contributor

Resolves #6925

Description

What is the purpose of this pull request?
Replaced tabs with spaces in lib/node_modules/@stdlib/_tools/scaffold/math-strided-binary-by/scripts/scaffold.sh
lib/node_modules/@stdlib/assert/napi/is-typedarray/manifest.json is already fixed.

Related Issues

#6925

Checklist


@stdlib-js/reviewers

LalitNarayanYadav and others added 12 commits May 5, 2025 13:50
Co-authored-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 6, 2025
@ShabiShett07
Copy link
Contributor

Hello @LalitNarayanYadav, you have done the same mistake as your previous PR. You have modified .github/workflows/run_tests_coverage.yml which was not expected.

@kgryte
Copy link
Member

kgryte commented May 8, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 8, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 8, 2025
@kgryte
Copy link
Member

kgryte commented May 8, 2025

As the CI failure does not seem to be due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit 669f8e5 into stdlib-js:develop May 8, 2025
9 of 11 checks passed
@LalitNarayanYadav LalitNarayanYadav deleted the fix-6925 branch May 8, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors

4 participants