Skip to content

chore: fix JavaScript lint errors (issue #7019) #7020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

chore: fix JavaScript lint errors (issue #7019) #7020

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfbd37f
chore: fix JavaScript lint errors (issue #7019)
udaykakade25 May 17, 2025
4abecc0
Update main.js
udaykakade25 May 17, 2025
6a4721e
Merge branch 'stdlib-js:develop' into stdlib_branch
udaykakade25 May 17, 2025
e77f54c
Merge branch 'stdlib-js:develop' into stdlib_branch
udaykakade25 May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/node_modules/@stdlib/plot/components/svg/marks/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,11 @@ function Marks( options ) {
* @private
*/
function onRender() {
var args;
var args = ['render'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var args = ['render'];
var args;

var i;
debug( 'Received a render event. Re-emitting...' );
args = new Array( arguments.length+1 );
args[ 0 ] = 'render';
for ( i = 0; i < arguments.length; i++ ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for ( i = 0; i < arguments.length; i++ ) {
args = [];
args[ 0 ] = 'render';
for ( i = 0; i < arguments.length; i++ ) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work

args[ i+1 ] = arguments[ i ];
args.push(arguments[i]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
args.push(arguments[i]);
args.push( arguments[ i ] );

}
self.emit.apply( self, args );
}
Expand Down
Loading