Skip to content

fix: add missing imports in ndarray/base/every-by #7108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add missing imports in ndarray/base/every-by #7108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/node_modules/@stdlib/ndarray/base/every-by/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ var EVERY = [
every7d,
every8d,
every9d,
every10d
every10d,
everynd
Comment on lines +83 to +84
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. nd should not be included in either list. Analyze the code below and understand how and why MAX_DIMS is used.

];
var ACCESSOR_EVERY = [
accessorevery0d,
Expand All @@ -93,7 +94,8 @@ var ACCESSOR_EVERY = [
accessorevery7d,
accessorevery8d,
accessorevery9d,
accessorevery10d
accessorevery10d,
accessoreverynd
];
var BLOCKED_EVERY = [
blockedevery2d, // 0
Expand Down