Skip to content

Conversation

karanlvm
Copy link
Contributor

Resolves #7115.

Description

What is the purpose of this pull request?

This pull request:

  1. Disallowed new Array() Constructor
    File: lib/node_modules/@stdlib/_tools/makie/plugins/makie-repl/lib/main.js
  • Replaced new Array(2) with an array literal: [] and used push() to populate it.
  1. Missing Namespace Export
  • lib/node_modules/@stdlib/string/lib/index.js

  • Issue: The module @stdlib/string/num-code-points was not exported from the string namespace.

  • Fix: Added the following export in the correct alphabetical position:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels May 31, 2025
@Swapnil-2502
Copy link
Contributor

You need to ignore warnings. I don't think so we need to remove comments.

@karanlvm karanlvm marked this pull request as draft May 31, 2025 05:54
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 31, 2025
@karanlvm karanlvm closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants