Skip to content

refactor: rename variable in blas/base/srotg #7209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

refactor: rename variable in blas/base/srotg #7209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/node_modules/@stdlib/blas/base/srotg/lib/assign.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

// MODULES //

var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var f32 = require( '@stdlib/number/float64/base/to-float32' );
var absf = require( '@stdlib/math/base/special/absf' );
var sqrtf = require( '@stdlib/math/base/special/sqrtf' );
var abs2f = require( '@stdlib/math/base/special/abs2f' );
Expand Down Expand Up @@ -62,22 +62,22 @@ function srotg( a, b, out, stride, offset ) {
} else {
sign = copysignf( 1.0, b );
}
scale = float64ToFloat32( aa + ab );
scale = f32( aa + ab );
if ( scale === 0.0 ) {
c = 1.0;
s = 0.0;
r = 0.0;
z = 0.0;
} else {
r = float64ToFloat32( scale * sqrtf( float64ToFloat32( abs2f( float64ToFloat32( a/scale ) ) + abs2f( float64ToFloat32( b/scale ) ) ) ) ); // eslint-disable-line max-len
r = float64ToFloat32( r * sign );
c = float64ToFloat32( a / r );
s = float64ToFloat32( b / r );
r = f32( scale * sqrtf( f32( abs2f( f32( a/scale ) ) + abs2f( f32( b/scale ) ) ) ) ); // eslint-disable-line max-len
r = f32( r * sign );
c = f32( a / r );
s = f32( b / r );
z = 1.0;
if ( aa > ab ) {
z = s;
} else if ( c !== 0.0 ) {
z = float64ToFloat32( 1.0 / c );
z = f32( 1.0 / c );
}
}
a = r;
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/base/srotg/test/test.assign.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var tape = require( 'tape' );
var Float32Array = require( '@stdlib/array/float32' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var f32 = require( '@stdlib/number/float64/base/to-float32' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var srotg = require( './../lib/assign.js' );

Expand Down Expand Up @@ -70,7 +70,7 @@ tape( 'the function computes a Givens plane rotation', function test( t ) {
for ( i = 0; i < values.length; i++ ) {
expected[i] = new Float32Array( expected[i] );
out = new Float32Array( 4 );
srotg( float64ToFloat32( values[i][0] ), float64ToFloat32( values[i][1] ), out, 1, 0 ); // eslint-disable-line max-len
srotg( f32( values[i][0] ), f32( values[i][1] ), out, 1, 0 );
t.deepEqual( out, expected[i], 'returns expected value' );
}
t.end();
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/base/srotg/test/test.main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var tape = require( 'tape' );
var Float32Array = require( '@stdlib/array/float32' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var f32 = require( '@stdlib/number/float64/base/to-float32' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var srotg = require( './../lib/main.js' );

Expand Down Expand Up @@ -69,7 +69,7 @@ tape( 'the function computes a Givens plane rotation', function test( t ) {

for ( i = 0; i < values.length; i++ ) {
expected[i] = new Float32Array( expected[i] );
out = srotg( float64ToFloat32( values[i][0] ), float64ToFloat32( values[i][1] ) ); // eslint-disable-line max-len
out = srotg( f32( values[i][0] ), f32( values[i][1] ) );
t.deepEqual( out, expected[i], 'returns expected value' );
}
t.end();
Expand Down
Loading