Skip to content

Conversation

Deepak91168
Copy link
Contributor


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: na
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #7215

Description

What is the purpose of this pull request?

This pull request:

  • Fixes Wrong indent style ( 2 - 6 ) in lib/node_modules/@stdlib/_tools/benchmarks/browser-build/lib/defaults.json
  • Fixes Wrong indent style ( 2-39 ) in lib/node_modules/@stdlib/ndarray/base/napi/typedarray-type-to-dtype/manifest.json

Related Issues

Does this pull request have any related issues?
No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jun 5, 2025
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Deepak91168
Copy link
Contributor Author

Hi maintainers,

I wanted to update that I ran all the relevant tests locally for the modified packages (@stdlib/_tools/benchmarks/browser-build and @stdlib/ndarray/base/napi/typedarray-type-to-dtype), and all tests passed successfully with no errors.

The CI failures seem to be related to the code coverage instrumentation step (make test-javascript-cov) rather than the changes I made, which were limited to fixing indentation styles in JSON files.

Could you please provide direction for addressing this issue!

Thanks for your support!

@kgryte
Copy link
Member

kgryte commented Jun 6, 2025

@Deepak91168 The CI failure is not due to you, and you can ignore.

@kgryte
Copy link
Member

kgryte commented Jun 6, 2025

@Planeshifter We need to filter out packages in the _tools directory, as the coverage command chokes when they are present. This is a fairly common occurrence and the cause of new contributors attempting to debug when there is no solution.

@Deepak91168
Copy link
Contributor Author

@Deepak91168 The CI failure is not due to you, and you can ignore.

Hi, just a query
Next time whenever I make PR
I should avoid Editing _tool ? To avoid CI failure in future PRs?

@kgryte
Copy link
Member

kgryte commented Jun 7, 2025

@Deepak91168 No, it is fine to edit _tools. It is just something we need to be aware of during review when evaluating the importance of CI failures until the workflow has been fixed.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing, @Deepak91168!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 7, 2025
@kgryte kgryte merged commit 3e432af into stdlib-js:develop Jun 7, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors

3 participants