-
-
Notifications
You must be signed in to change notification settings - Fork 997
chore: fix EditorConfig lint errors (issue #7215) #7226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
Hi maintainers, I wanted to update that I ran all the relevant tests locally for the modified packages (@stdlib/_tools/benchmarks/browser-build and @stdlib/ndarray/base/napi/typedarray-type-to-dtype), and all tests passed successfully with no errors. The CI failures seem to be related to the code coverage instrumentation step (make test-javascript-cov) rather than the changes I made, which were limited to fixing indentation styles in JSON files. Could you please provide direction for addressing this issue! Thanks for your support! |
|
@Deepak91168 The CI failure is not due to you, and you can ignore. |
|
@Planeshifter We need to filter out packages in the |
Hi, just a query |
|
@Deepak91168 No, it is fine to edit |
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing, @Deepak91168!
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #7215
Description
This pull request:
lib/node_modules/@stdlib/_tools/benchmarks/browser-build/lib/defaults.jsonlib/node_modules/@stdlib/ndarray/base/napi/typedarray-type-to-dtype/manifest.jsonRelated Issues
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers