test: add missing tests to `ndarray/base/every` #7235

headlessNode · 2025-06-06T09:44:08Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: na
task: lint_package_json status: na
task: lint_repl_help status: na
task: lint_javascript_src status: na
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: na
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: na
task: lint_typescript_tests status: na
task: lint_license_headers status: passed ---

Progresses #2656.

Description

What is the purpose of this pull request?

This pull request:

add tests for 100% code coverage.

Related Issues

Does this pull request have any related issues?

This pull request:

progresses [RFC]: achieve ndarray API parity with built-in JavaScript arrays #2656.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-06-06T09:46:10Z

Coverage Report

Package	Statements	Branches	Functions	Lines
ndarray/base/every	$\color{red}12000/12006$ $\color{green}+99.95\%$	$\color{red}1464/1468$ $\color{green}+99.73\%$	$\color{green}64/64$ $\color{green}+100.00\%$	$\color{red}12000/12006$ $\color{green}+99.95\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js

Signed-off-by: Muhammad Haris <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

headlessNode · 2025-06-09T10:30:44Z

Headsup, working on 100% coverage for accessors.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/ndarray/base/every/test/test.1d.js

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js

kgryte

Apart from the two instances where strides are not in column-major order, these tests are looking good.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/ndarray/base/every/test/test.3d.js

Signed-off-by: Muhammad Haris <[email protected]>

lib/node_modules/@stdlib/ndarray/base/every/test/test.4d.js

lib/node_modules/@stdlib/ndarray/base/every/test/test.5d.js

lib/node_modules/@stdlib/ndarray/base/every/test/test.6d.js

lib/node_modules/@stdlib/ndarray/base/every/test/test.7d.js

lib/node_modules/@stdlib/ndarray/base/every/test/test.8d.js

lib/node_modules/@stdlib/ndarray/base/every/test/test.9d.js

lib/node_modules/@stdlib/ndarray/base/every/test/test.nd.js

lib/node_modules/@stdlib/ndarray/base/every/test/test.10d.js

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode · 2025-06-17T09:16:18Z

Heads up! It appears strides for non-contiguous cases without large arrays maybe incorrect.

lib/node_modules/@stdlib/ndarray/base/every/test/test.5d.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

headlessNode · 2025-06-17T21:13:32Z

@kgryte ready for review.

kgryte

LGTM. Thanks for adding these, @headlessNode!

headlessNode added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). Tests Pull requests specifically adding tests. labels Jun 6, 2025

headlessNode commented Jun 6, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js Outdated Show resolved Hide resolved

chore: fix comment

d56c204

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode requested a review from kgryte June 6, 2025 12:12

stdlib-bot added the Needs Review A pull request which needs code review. label Jun 6, 2025

headlessNode mentioned this pull request Jun 9, 2025

Weekly Standup (2025-06-09) stdlib-js/google-summer-of-code#157

Closed

headlessNode commented Jun 10, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/every/test/test.1d.js Outdated Show resolved Hide resolved

lib/node_modules/@stdlib/ndarray/base/every/test/test.1d.js Outdated Show resolved Hide resolved

refactor: apply suggestions from code review

bfabd7d

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode commented Jun 10, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js Outdated Show resolved Hide resolved

fix: import

d28a6af

Signed-off-by: Muhammad Haris <[email protected]>

kgryte reviewed Jun 11, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js Outdated Show resolved Hide resolved

kgryte reviewed Jun 11, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/every/test/test.2d.js Outdated Show resolved Hide resolved

kgryte reviewed Jun 11, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Jun 11, 2025

headlessNode added 8 commits June 14, 2025 17:19

headlessNode added 2 commits June 16, 2025 05:53

headlessNode marked this pull request as ready for review June 16, 2025 06:23

stdlib-bot added the Needs Review A pull request which needs code review. label Jun 16, 2025

headlessNode requested a review from kgryte June 16, 2025 06:23

headlessNode mentioned this pull request Jun 16, 2025

Weekly Standup (2025-06-16) stdlib-js/google-summer-of-code#158

Closed

headlessNode commented Jun 16, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/every/test/test.3d.js Outdated Show resolved Hide resolved

fix: order

b61bb96

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode commented Jun 16, 2025

View reviewed changes

fix: apply suggestions from code review

1dd55b5

Signed-off-by: Muhammad Haris <[email protected]>

headlessNode commented Jun 17, 2025

View reviewed changes

lib/node_modules/@stdlib/ndarray/base/every/test/test.5d.js Outdated Show resolved Hide resolved

kgryte approved these changes Jun 22, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Jun 22, 2025

kgryte merged commit b479fcf into stdlib-js:develop Jun 22, 2025
10 checks passed

headlessNode deleted the test-every branch June 23, 2025 05:28

headlessNode mentioned this pull request Jun 23, 2025

Weekly Standup (2025-06-23) stdlib-js/google-summer-of-code#159

Closed

Uh oh!

test: add missing tests to ndarray/base/every #7235

test: add missing tests to ndarray/base/every #7235

Uh oh!

Conversation

headlessNode commented Jun 6, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

headlessNode commented Jun 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

headlessNode commented Jun 17, 2025

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

test: add missing tests to `ndarray/base/every` #7235

test: add missing tests to `ndarray/base/every` #7235

stdlib-bot commented Jun 6, 2025 •

edited

Loading

headlessNode commented Jun 17, 2025 •

edited

Loading